Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blank AA Display #202

Closed
veroniquevoisin opened this issue Feb 29, 2024 · 21 comments
Closed

blank AA Display #202

veroniquevoisin opened this issue Feb 29, 2024 · 21 comments
Assignees
Milestone

Comments

@veroniquevoisin
Copy link

veroniquevoisin commented Feb 29, 2024

While creating a map, I got a blank AutoAnnotate Display.
It was different from the frozen display as it was not flickering.
I tried to unpin/pinbut it did not work.
Then I decided to redraw the annotation, I got an error message that I needed to use clusterMaker app set to none for the edge weight and it worked. Not sure if related to the blank issue.
<img width="884" alt="Screenshot 2024-02-28 at 9 22 33 PM"
<img width="997" alt="Screenshot 2024-02-28 at 9 22 28 PM"
Screenshot 2024-02-28 at 9 21 44 PM
src="https://github.com/BaderLab/AutoAnnotateApp/assets/7570379/bfacc7ff-14df-4f22-ad38-395a511ecec8">
src="https://github.com/BaderLab/AutoAnnotateApp/assets/7570379/81d6a85e-ccb0-483f-8a6e-64530d4b607a">

@veroniquevoisin
Copy link
Author

Screenshot 2024-02-28 at 9 22 28 PM

@mikekucera mikekucera self-assigned this Feb 29, 2024
@mikekucera mikekucera added this to the 1.5 milestone Feb 29, 2024
@mikekucera
Copy link
Collaborator

Hi Veronique,
I'm going to need the session file or data files to try to reproduce this. Could you also please send your framework.log file because that might have an error trace in it.

@veroniquevoisin
Copy link
Author

veroniquevoisin commented Mar 1, 2024

I was able to reproduce and caught the error on the log:

Screenshot 2024-03-01 at 4 21 30 PM

Screenshot 2024-03-01 at 4 21 39 PM

@mikekucera
Copy link
Collaborator

Hi Veronique, I'm not sure what's going on here. I'm not able to reproduce this issue with the session file you sent.

The screenshot of your log file says that the 'similarity_coefficient' column of the 'basalA.GseaPreranked' node table is missing. The session file you sent me doesn't have a network named 'basalA.GseaPreranked'.

Do you remember exactly what you were doing when you encountered this bug? Are you still able to reproduce it?

@veroniquevoisin
Copy link
Author

It happens when I create a map with GSEA result from 1 data that I have.
Here is the session that I just redid. I just created the map with the one dataset.
https://www.dropbox.com/scl/fi/vjkzj53r0e98md7tihp2u/testmikeMAr11.cys?rlkey=vpd01qbx45is4bm674hm1xt5c&dl=0

@veroniquevoisin
Copy link
Author

Screenshot 2024-03-11 at 12 28 01 PM

@mikekucera
Copy link
Collaborator

So the error happens while creating the enrichment map network, right? Not when creating annotations after the network has already been created.
If so can you please send me the data files you used to create the network. Thanks.

@veroniquevoisin
Copy link
Author

yes correct
here is the gsea result: https://www.dropbox.com/scl/fo/7qnhc6qxilyjcgkeueb8r/h?rlkey=udhvdtzrw9wnckvimjrihx4cd&dl=0
The issue is only with classicB

@veroniquevoisin
Copy link
Author

veroniquevoisin commented Mar 12, 2024

I got the issue again with gprofiler results with latest builts of AA and EM

Screenshot 2024-03-12 at 11 35 02 AM

@veroniquevoisin
Copy link
Author

Do you think that the default should be? Although I can see that with this option, we can't control the number of clusters. Can you do that from clustermaker MCL granularity parameter?
Screenshot 2024-03-12 at 11 33 01 AM

Screenshot 2024-03-12 at 11 37 33 AM

@veroniquevoisin
Copy link
Author

gprofiler file that Iused:
gProfiler_hsapiens_3-12-2024_11-06-35 AM.gem.txt

@veroniquevoisin
Copy link
Author

veroniquevoisin commented Mar 12, 2024

closed and opened Cytoscape and it worked:

Screenshot 2024-03-12 at 12 09 24 PM

@mikekucera
Copy link
Collaborator

Your latest error log screenshot is interesting. I noticed it says it can't find the 'similarity_coefficient' column in the node table, of course it can't its in the edge table.
Could you please send me your framework.log file. I'm starting to think this is a bug in clusterMaker.

@veroniquevoisin
Copy link
Author

@veroniquevoisin
Copy link
Author

Screenshot 2024-03-12 at 2 43 52 PM

@veroniquevoisin
Copy link
Author

Where can I find the framework.log file?

@mikekucera
Copy link
Collaborator

In the <user-home>/CytoscapeConfiguration/3 folder, its called framework-cytoscape.log

@veroniquevoisin
Copy link
Author

framework-cytoscape.log

@veroniquevoisin
Copy link
Author

here it. is

@mikekucera
Copy link
Collaborator

I think we are running into this bug in clusterMaker: RBVI/clusterMaker2#10

The issue is that the MCL command remembers the range of values used for the edge attribute. If you run the MCL command a second time on a different network or attribute it does not update the range properly. This can lead to an exception.

I don't think the bug in clusterMaker is going to be fixed (its been open since 2017). I thought I had already found a way of working around the bug, but now its showing up again. I'll have to figure out why and maybe find a new way of working around it.

Another option would be to use a different clustering algorithm as the default. I think everyone is happy with MCL so I'll take a stab at fixing this first.

@mikekucera
Copy link
Collaborator

I removed the use of the cutoff parameter.
ba4a9be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants