Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take http status code as a configuration value #55

Open
freman opened this issue Oct 30, 2019 · 4 comments · May be fixed by #56
Open

Take http status code as a configuration value #55

freman opened this issue Oct 30, 2019 · 4 comments · May be fixed by #56

Comments

@freman
Copy link

freman commented Oct 30, 2019

Hi,

We would like to be able to configure the status code, specifically instead of 303 we want to use 307

Maybe a config property RedirectCode=307 or have a ,307 after the url?

(edited to correct copy pasta typo)

@magikstm
Copy link
Contributor

Are you using caddy-jwt by itself or with another plugin?

@freman
Copy link
Author

freman commented Oct 30, 2019

by itself, it redirects to our auth server (I mean with a whole bunch of plugins in caddy but not generally with caddy-jwt)

@BTBurke
Copy link
Owner

BTBurke commented Oct 30, 2019

I don't think that is going to happen. Caddy 2 will be coming out in a few months and all of the existing plugins will have to be rewritten to work with the new module system. I haven't decided yet whether I'll port the JWT plugin or let someone else take over, but with the new design there should be more flexibility to decide how you want it to redirect.

@freman freman linked a pull request Oct 30, 2019 that will close this issue
@freman
Copy link
Author

freman commented Oct 30, 2019

Aww, but I already did it :D

Caddy 2 will be coming out in a few months and all of the existing plugins will have to be rewritten to work with the new module system

I assure you, I feel your pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants