Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_metadata.py - failed upload handling #36

Open
chkw opened this issue Jul 9, 2016 · 1 comment
Open

generate_metadata.py - failed upload handling #36

chkw opened this issue Jul 9, 2016 · 1 comment

Comments

@chkw
Copy link
Contributor

chkw commented Jul 9, 2016

generate_metadata.py currently handles failed uploads in the following way:

  1. reports number of failed uploads
  2. writes output from the upload client jar to a log file

Is this sufficient, or should the script do something more elaborate?

@chkw chkw changed the title failed upload handling generate_metadata.py failed upload handling Jul 9, 2016
@chkw chkw changed the title generate_metadata.py failed upload handling generate_metadata.py - failed upload handling Jul 9, 2016
@chkw chkw added the ready label Jul 9, 2016
@hannes-ucsc
Copy link

Not familiar with this particular script, but generally speaking a program should exit with a non-zero exit code if it failed for any part of its inputs. It's ok to do proceed with other inputs after one them failed, but the failure should still result in a non-zero exit code, even if subsequent inputs succeeded.

@kozbo kozbo removed the ready label Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants