Error if same named type importable #8927
Open
+265
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed 'name' to match others - "duplicate-import-type". Corrected the error code - "C4764". Moved the register function to the end of the file with all of the other ones.
close added to reset when moving to the next file to ensure no false errors
Changes made so that the duplicates throw an error if they are in the same folder and not in an IF or other condition statement
|
@l0lawrence can you review/route? |
|
/azp run tools - azure-pylint-guidelines-checker - ci |
|
Pull request contains merge conflicts. |
l0lawrence
reviewed
Sep 5, 2024
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Outdated
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Outdated
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Outdated
Show resolved
Hide resolved
Merge azure-sdk-tools main into main
# Conflicts: # tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py # tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py
Spaces in the syntax removed and a test for special cases added
|
@microsoft-github-policy-service agree |
l0lawrence
reviewed
Sep 19, 2024
tools/pylint-extensions/azure-pylint-guidelines-checker/tests/test_pylint_custom_plugins.py
Outdated
Show resolved
Hide resolved
tools/pylint-extensions/azure-pylint-guidelines-checker/pylint_guidelines_checker.py
Outdated
Show resolved
Hide resolved
l0lawrence
reviewed
Sep 26, 2024
| @@ -2902,10 +2957,12 @@ def register(linter): | |||
| linter.register_checker(DeleteOperationReturnStatement(linter)) | |||
| linter.register_checker(ClientMethodsHaveTracingDecorators(linter)) | |||
| linter.register_checker(DoNotImportLegacySix(linter)) | |||
| linter.register_checker(DoNotImportAsyncio(linter)) | |||
| msgs = { | ||
| "C4764": ( | ||
| "Type %s is imported multiple times from the same module: %s", | ||
| "duplicate-import-type", |
There was a problem hiding this comment.
can we align this with the name above and make that also duplicate-import-type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Throws an error when there is a duplicate import in the same file.