Add Kotlin lang #4221
Add Kotlin lang #4221
Conversation
| if (KotlinASTAnalyser.hasPublicApiInKotlin(unzippedFile.getAbsolutePath())) { | ||
| apiListing.setLanguage("Kotlin"); | ||
| final KotlinASTAnalyser kotlinAnalyser = new KotlinASTAnalyser(apiListing); | ||
| kotlinAnalyser.analyse(unzippedFile.getAbsolutePath()); |
There was a problem hiding this comment.
Do you think it would be possible to give the KotlinAnalyser a custom FileSystem (consisting of the jar file) like I do for the Java listing below? That would avoid having to unzip.
There was a problem hiding this comment.
@JonathanGiles underlying Dokka API that is used to parse Kotlin AST only takes java.io.File and that needs to be a directory. I did not find a way to virtualize that.
There was a problem hiding this comment.
I reckon you could do more or less what I have done, but rather than pass in the files individually, pass in the root directory. I would really like to see you try that, as it pains me (and I'm sure you) to see the files be unzipped in all cases!
There was a problem hiding this comment.
I do pass a root directory here unzippedFile.getAbsolutePath(). I do agree that it is far from ideal to unzip to the file system (not virtual one), but eventually I pass this root directory path to the Dokka, that only takes java.io.File which does not support virtual file system.
src/java/apiview-java-processor/result/final-1.0.2-sources.json
Outdated
Show resolved
Hide resolved
| if (KotlinASTAnalyser.hasPublicApiInKotlin(unzippedFile.getAbsolutePath())) { | ||
| apiListing.setLanguage("Kotlin"); | ||
| final KotlinASTAnalyser kotlinAnalyser = new KotlinASTAnalyser(apiListing); | ||
| kotlinAnalyser.analyse(unzippedFile.getAbsolutePath()); |
There was a problem hiding this comment.
I reckon you could do more or less what I have done, but rather than pass in the files individually, pass in the root directory. I would really like to see you try that, as it pains me (and I'm sure you) to see the files be unzipped in all cases!
ghost
added
the
no-recent-activity
|
Hi @pavelprystinka. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
|
Hi @pavelprystinka. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
github-actions
bot
removed
the
no-recent-activity
|
Sorry @pavelprystinka - this keeps dropping on the floor. Could you please update the code to fix the conflicts, and we can take another look. |
|
Hi @pavelprystinka. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days. |
github-actions
bot
added
the
no-recent-activity
|
Hi @pavelprystinka. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing |
github-actions
bot
removed
the
no-recent-activity
No description provided.