From 1bcc13d00dc83a5690c92cfb5154275d38aa5a6a Mon Sep 17 00:00:00 2001 From: Charles Lowell <10964656+chlowell@users.noreply.github.com> Date: Fri, 4 Oct 2024 14:19:34 -0700 Subject: [PATCH] Name anonymous struct types in azidentity tests --- sdk/azidentity/client_assertion_credential_test.go | 6 +++--- sdk/azidentity/device_code_credential_test.go | 3 ++- sdk/azidentity/on_behalf_of_credential_test.go | 6 +++--- 3 files changed, 8 insertions(+), 7 deletions(-) diff --git a/sdk/azidentity/client_assertion_credential_test.go b/sdk/azidentity/client_assertion_credential_test.go index 6773749b9847..482f2e173811 100644 --- a/sdk/azidentity/client_assertion_credential_test.go +++ b/sdk/azidentity/client_assertion_credential_test.go @@ -18,10 +18,10 @@ import ( ) func TestClientAssertionCredential(t *testing.T) { - key := struct{}{} + type key struct{} calls := 0 getAssertion := func(c context.Context) (string, error) { - if v := c.Value(key); v == nil || !v.(bool) { + if v := c.Value(key{}); v == nil || !v.(bool) { t.Fatal("unexpected context in getAssertion") } calls++ @@ -33,7 +33,7 @@ func TestClientAssertionCredential(t *testing.T) { if err != nil { t.Fatal(err) } - ctx := context.WithValue(context.Background(), key, true) + ctx := context.WithValue(context.Background(), key{}, true) _, err = cred.GetToken(ctx, testTRO) if err != nil { t.Fatal(err) diff --git a/sdk/azidentity/device_code_credential_test.go b/sdk/azidentity/device_code_credential_test.go index 5a00a0eaa3cb..b99aec0ab5e0 100644 --- a/sdk/azidentity/device_code_credential_test.go +++ b/sdk/azidentity/device_code_credential_test.go @@ -29,7 +29,8 @@ func TestDeviceCodeCredential_GetTokenInvalidCredentials(t *testing.T) { } func TestDeviceCodeCredential_UserPromptError(t *testing.T) { - expectedCtx := context.WithValue(context.Background(), struct{}{}, "") + type key struct{} + expectedCtx := context.WithValue(context.Background(), key{}, "") expected := DeviceCodeMessage{UserCode: "user code", VerificationURL: "http://localhost", Message: "message"} success := "it worked" options := DeviceCodeCredentialOptions{ diff --git a/sdk/azidentity/on_behalf_of_credential_test.go b/sdk/azidentity/on_behalf_of_credential_test.go index 2c7bedde0d74..20ecba74ed03 100644 --- a/sdk/azidentity/on_behalf_of_credential_test.go +++ b/sdk/azidentity/on_behalf_of_credential_test.go @@ -74,12 +74,12 @@ func TestOnBehalfOfCredential(t *testing.T) { }, } { t.Run(test.name, func(t *testing.T) { - key := struct{}{} - ctx := context.WithValue(context.Background(), key, true) + type key struct{} + ctx := context.WithValue(context.Background(), key{}, true) srv := mockSTS{tokenRequestCallback: func(r *http.Request) *http.Response { if c := r.Context(); c == nil { t.Fatal("AcquireTokenOnBehalfOf received no Context") - } else if v := c.Value(key); v == nil || !v.(bool) { + } else if v := c.Value(key{}); v == nil || !v.(bool) { t.Fatal("AcquireTokenOnBehalfOf received unexpected Context") } if err := r.ParseForm(); err != nil {