Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azeventhubs] Breaking change required to accomodate offsets that are _truly_ strings #23498

Open
richardpark-msft opened this issue Sep 25, 2024 · 3 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@richardpark-msft
Copy link
Member

richardpark-msft commented Sep 25, 2024

Event Hubs events have an 'Offset' property, which has been typed as a integer in our SDK, but is actually (on the wire) a string.

This is incorrect and based on upcoming features, we need to do a breaking change to the API surface, where Offset will be properly typed as a 'string' and match the underlying protocol.

This will involve changes in the following places:

  • ReceivedEventData.Offset, int64 -> string
  • Checkpoint.Offset *int64 -> *string
  • PartitionProperties.LastEnqueuedOffset int64 -> string
  • StartPosition.Offset *int64 -> *string

(there might be others, but these are definitely the most obvious ones)

@richardpark-msft richardpark-msft self-assigned this Sep 25, 2024
@richardpark-msft richardpark-msft added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Sep 25, 2024
@github-actions github-actions bot added the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 25, 2024
Copy link

Thank you for your feedback. Tagging and routing to the team member best able to assist.

@richardpark-msft richardpark-msft removed the needs-team-attention Workflow: This issue needs attention from Azure service team or SDK team label Sep 25, 2024
@jhendrixMSFT
Copy link
Member

What's driving this requirement, is it the ability to specify values that aren't numeric?

@richardpark-msft
Copy link
Member Author

richardpark-msft commented Sep 26, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

2 participants