Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cliff sensor support #22

Open
jacobperron opened this issue Apr 19, 2016 · 5 comments
Open

Add cliff sensor support #22

jacobperron opened this issue Apr 19, 2016 · 5 comments

Comments

@jacobperron
Copy link
Member

At the very least the driver can publish a Boolean message signalling whether or not a cliff is detected.
Alternatively, can also publish a custom message similar to the Bumper message, that contains the raw signal strengths as well as the Boolean cliff signals for all four sensors.

@jacobperron jacobperron added this to the 2.0.0 milestone Apr 19, 2016
@betaupsx86
Copy link

Yep definitely. I added Cliff custom messages while working with the driver. Just let me know if you are open to contributions

@jacobperron
Copy link
Member Author

@betaupsx86 Definitely open for contributions :)

@Dcruise546
Copy link

@betaupsx86 Is there any update on the cliff custom message? I am trying to use the sensor for an experimental docking mechanism. Any help will be much appreciated!

@girvenavery2022
Copy link

Hi @jacobperron, I just finished this feature and tested it on my create2. I can confirm it works and can open a pr to contribute it!

@jacobperron
Copy link
Member Author

@girvenavery2022 There is already a PR adding this feature (#93). Sorry, I've just been slow at getting around to testing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants