Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old (scaled) images not reset if big_image_size_threshold increased or removed #104

Open
roundhill opened this issue May 22, 2020 · 14 comments

Comments

@roundhill
Copy link

Reported at: https://wordpress.org/support/topic/old-scaled-images-not-reset-if-big_image_size_threshold-increased-or-removed/

If I use the big_image_size_threshold hook to increase or remove scaling of large images on a site with existing media, the plugin continues to uses the “scaled” images as the source, rather than looking at the “original_image” src to decide wether larger images should be created.

In this scenario, if the big_image_size_threshold filter is used to disable the big image threshold, I believe the _wp_attached_file meta value should be changed to the “original_image” src URL prior to regenerating images.

If the big_image_size_threshold filter is used to change the big image threshold, I believe the _wp_attached_file meta value should generate a new version of the ‘scaled’ image at the size defined by big_image_size_threshold.

@alexsanford alexsanford added the [Status] Queued In the queue of issues to work on next. label Jun 12, 2020
@simplenotezy
Copy link

We have the same issue. It looks for: /uploads/2020/06/005612-4-24x24.jpg rather than /uploads/2020/06/005612-4-scaled-24x24.jpg. I guess regenerating the thumbnails could fix the issue

@ddegner
Copy link

ddegner commented Sep 4, 2020

Also same issue. I'm trying to figure out how to either serve the original image or regenerate the "scaled" image to a larger version, but no luck yet.

@ThinkWired
Copy link

ThinkWired commented Dec 23, 2020

+1 This is a must have, to fix the 5.3 debacle.

@renatho
Copy link
Contributor

renatho commented May 24, 2021

@ddegner
Copy link

ddegner commented Jul 2, 2021

I'd like to give this another bump to this bug. The plugin is only hobbling along until this is fixed. Most users probably just don't realize that it isn't working until much later.

@SeanAUS120
Copy link

SeanAUS120 commented Dec 7, 2021

1 year later and there is still no way to "revert" back to the original images. What a horrifying feature from Wordpress.

@gamebits
Copy link

I use this snippet to disable scaling:

add_filter( 'big_image_size_threshold', '__return_false' );

No -scaled version of the file is created when it's first uploaded. But after I regenerate thumbnails, the original file is renamed to -scaled and can't be renamed back.

Screencast:

Regenerate.Thumbnails.mp4

@SeanAUS120
Copy link

2 years later. Did anyone come up with a solution to remove the existing -scaled images?

@ddur
Copy link

ddur commented Jul 27, 2022

@SeanAUS120
Try with this plugin:
https://github.com/ddur/Warp-iMagick

@ddegner
Copy link

ddegner commented Jul 27, 2022 via email

@ddur
Copy link

ddur commented Jul 28, 2022

@ddegner

I used to use the Warp-iMagick app, but the owner sold out about 5 months ago, and it is now trojaned. Avoid at all costs.

BS. I'm original author and still owner. No trojans if you got the unmodified plugin from the original link.

If you want to know what actually happened, read here the full story:
https://community.wordops.net/d/1297-convert-jpegpng-to-webp-on-demand-on-the-fly-for-wordops/23

@ddur
Copy link

ddur commented Jul 28, 2022

@ddegner

While plugin was available from WordPress repository, A2 hosting used to distribute and install plugin automatically to a2 WordPress hosting buyers. Without my knowledge and without my consent, but that is how GPL license works.

Where did you get that disinformation and lies?

@ddur
Copy link

ddur commented Jul 28, 2022

BTW only one member of plugin review "team" is paid by another hosting "dream-host"
See the "case study" here: https://wordpress.org/five-for-the-future/

How the single member "team" monopoly (paid by dream host) over plugin repository started?
Unbelievable post from 2014: https://make.wordpress.org/plugins/2014/11/03/post-summit-status/

Comment from (then) team member in 2014: https://make.wordpress.org/updates/2014/11/07/plugins-update-for-november-6-2014/

Until 2014, plugin review team had at least 3 (quality) members I could find in the plugin review posting.
https://profiles.wordpress.org/boonebgorges/
https://profiles.wordpress.org/coffee2code/
https://profiles.wordpress.org/mordauk/

Since 2015, after coup, there are no other "team" members posting here:
https://make.wordpress.org/updates/tag/plugins/

Since 2015, after coup, until today, no new plugin review team members can be accepted, due to "technical" limitations.
https://make.wordpress.org/plugins/handbook/get-involved/#become-a-reviewer

@gikaragia gikaragia removed the [Status] Queued In the queue of issues to work on next. label Dec 5, 2022
@picard102
Copy link

Has this been fixed yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests