Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floodfill on Pangea #635

Open
red-kangaroo opened this issue Oct 7, 2021 · 1 comment
Open

Floodfill on Pangea #635

red-kangaroo opened this issue Oct 7, 2021 · 1 comment

Comments

@red-kangaroo
Copy link
Contributor

When using Pangea world shape with wrapping edges (see #631), the generator puts all locations on a single "part" of the landmass - eg. if the continent goes north and warps to the south, all locations will only be in the northern part and the southern part will be empty, even though it's easily reachable. This is a limitation of the current location reachability check, which uses floodfill from the UT exit, not taking the wrapping world edges into account.

Floodfill that does take world edge wrapping into account and can place location on the whole continent would be nice.

@ryfactor
Copy link
Member

ryfactor commented Oct 22, 2021

This is a limitation of the current location reachability check, which uses floodfill from the UT exit, not taking the wrapping world edges into account.

Actually it's a limitation of the floodfill used to enumerate continents, e.g. continent number 1, 2, 3... etc. (I think this is done by worldmap::CalculateContinents() )
We need the continent calculator to connect landmasses on the other side of the worldmap by making them the same continent number. Everything else should fall into place :)

EDIT: It should operate this way only in the x-axis when the world shape is cylindrical, and in the x- and y-axes when the world shape is toroidal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants