Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pallet-ethereum-checked integration #976

Merged
merged 10 commits into from
Jul 18, 2023
Merged

Conversation

shaunxw
Copy link
Member

@shaunxw shaunxw commented Jul 13, 2023

Pull Request Summary

  • Integrate into pallet-xvm and Shibuya runtime
  • Update(fix) XVM weight handling
  • pallet-ethereum-checked benchmarking
  • Updated unit tests to cover tx apply result checks

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@shaunxw
Copy link
Member Author

shaunxw commented Jul 13, 2023

/bench shibuya-dev pallet_ethereum_checked

@shaunxw shaunxw added shibuya related to shibuya runtime This PR/Issue is related to the topic “runtime”. labels Jul 13, 2023
@github-actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/5541013210.
Please wait for a while.
Branch: feat/ethereum-checked-integration
SHA: 2f133fc

@github-actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/5541013210.

pallets/ethereum-checked/src/benchmarking.rs Outdated Show resolved Hide resolved
pallets/ethereum-checked/src/lib.rs Outdated Show resolved Hide resolved
pallets/ethereum-checked/src/weights.rs Show resolved Hide resolved
@shaunxw
Copy link
Member Author

shaunxw commented Jul 17, 2023

/bench shibuya-dev pallet_ethereum_checked

@github-actions
Copy link

Benchmarks job is scheduled at https://github.com/AstarNetwork/Astar/actions/runs/5574376111.
Please wait for a while.
Branch: feat/ethereum-checked-integration
SHA: 1bde842

@github-actions
Copy link

Benchmarks have been finished.
You can download artifacts if exists https://github.com/AstarNetwork/Astar/actions/runs/5574376111.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
chain-extensions/types/dapps-staking/src 0% 0%
pallets/block-reward/src 85% 0%
pallets/collator-selection/src 70% 0%
pallets/ethereum-checked/src 52% 0%
chain-extensions/xvm/src 0% 0%
chain-extensions/pallet-assets/src 0% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/pallet-xvm/src/pallet 8% 0%
precompiles/assets-erc20/src 76% 0%
precompiles/sr25519/src 79% 0%
precompiles/utils/src 69% 0%
pallets/pallet-xcm/src 54% 0%
precompiles/dapps-staking/src 93% 0%
pallets/dapps-staking/src/pallet 87% 0%
primitives/src/xcm 70% 0%
precompiles/substrate-ecdsa/src 78% 0%
chain-extensions/types/assets/src 0% 0%
pallets/pallet-xvm/src 5% 0%
pallets/dapps-staking/src 82% 0%
pallets/contracts-migration/src 0% 0%
precompiles/utils/macro/src 0% 0%
precompiles/xcm/src 85% 0%
pallets/xc-asset-config/src 54% 0%
precompiles/xvm/src 61% 0%
pallets/custom-signatures/src 52% 0%
primitives/src 72% 0%
chain-extensions/dapps-staking/src 0% 0%
Summary 55% (2244 / 4069) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shaunxw shaunxw merged commit 76ddb2a into master Jul 18, 2023
12 checks passed
@shaunxw shaunxw deleted the feat/ethereum-checked-integration branch July 18, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
runtime This PR/Issue is related to the topic “runtime”. shibuya related to shibuya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants