dApp Staking v3 - Incorrect Loyalty Status Fix

[Dinonard]

Pull Request Summary

Fixes an issue when loyalty status would persist even though staker fully unstaked during the Voting subperiod.

[github-actions]

Package	Line Rate	Branch Rate	Health
chain-extensions/xvm/src	0%	0%	❌
pallets/dapp-staking-v3/src/test	0%	0%	❌
precompiles/dapp-staking-v3/src	90%	0%	✔
pallets/xc-asset-config/src	53%	0%	➖
primitives/src	58%	0%	➖
precompiles/xcm/src	72%	0%	➖
pallets/inflation/src	69%	0%	➖
precompiles/xvm/src	74%	0%	➖
primitives/src/xcm	66%	0%	➖
pallets/dapp-staking-v3/src	76%	0%	➖
pallets/dapps-staking/src	81%	0%	✔
pallets/static-price-provider/src	58%	0%	➖
pallets/block-rewards-hybrid/src	87%	0%	✔
precompiles/unified-accounts/src	100%	0%	✔
precompiles/substrate-ecdsa/src	74%	0%	➖
chain-extensions/types/assets/src	0%	0%	❌
pallets/ethereum-checked/src	48%	0%	❌
pallets/astar-xcm-benchmarks/src	0%	0%	❌
pallets/dapp-staking-migration/src	39%	0%	❌
chain-extensions/unified-accounts/src	0%	0%	❌
pallets/dapps-staking/src/pallet	85%	0%	✔
pallets/astar-xcm-benchmarks/src/fungible	0%	0%	❌
pallets/dapp-staking-v3/src/benchmarking	0%	0%	❌
pallets/unified-accounts/src	84%	0%	✔
pallets/xvm/src	40%	0%	❌
chain-extensions/types/unified-accounts/src	0%	0%	❌
pallets/collator-selection/src	69%	0%	➖
precompiles/sr25519/src	64%	0%	➖
pallets/astar-xcm-benchmarks/src/generic	0%	0%	❌
chain-extensions/types/xvm/src	0%	0%	❌
pallets/dynamic-evm-base-fee/src	81%	0%	✔
precompiles/assets-erc20/src	81%	0%	✔
precompiles/dapp-staking-v3/src/test	0%	0%	❌
chain-extensions/pallet-assets/src	56%	0%	➖
pallets/dapp-staking-v3/rpc/runtime-api/src	0%	0%	❌
precompiles/dapps-staking/src	94%	0%	✔
Summary	70% (3261 / 4688)	0% (0 / 0)	➖

Minimum allowed line rate is 50%

[ashutoshvarma]

LGTM!
Do we need a separate (negative) test for loyal stakers just to make sure it doesn't popup in future?

[Dinonard]

LGTM! Do we need a separate (negative) test for loyal stakers just to make sure it doesn't popup in future?

The worst thing is that I wrote a test for this and set incorrect expectations, even added an incorrect comment. 🤦‍♂️
Current test covers partial & full-unstake during Voting, with appropriate checks.