Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo fixes and grammar #1090

Merged
merged 2 commits into from
Jan 2, 2024
Merged

fix: typo fixes and grammar #1090

merged 2 commits into from
Jan 2, 2024

Conversation

Amb1guousRaccoon
Copy link
Contributor

Pull Request Summary

README only change to clean up typos and grammar issues.

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • added benchmarks & weights for any modified runtime logics.

@Amb1guousRaccoon
Copy link
Contributor Author

@Dinonard any feedback? Happy to make more comprehensive updates too.

@Dinonard Dinonard added the documentation Add documentation label Jan 2, 2024
Dinonard
Dinonard approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dinonard Dinonard added the other PR/issue is related to third-party, scripts or other things which don't have definite label. label Jan 2, 2024
@Dinonard Dinonard merged commit 9e08ec1 into AstarNetwork:master Jan 2, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dinonard Dinonard Dinonard approved these changes

Assignees
No one assigned
Labels
documentation Add documentation other PR/issue is related to third-party, scripts or other things which don't have definite label.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amb1guousRaccoon @Dinonard