Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added concurrency for cancel previous runs #1029

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Added concurrency for cancel previous runs #1029

merged 1 commit into from
Sep 25, 2023

Conversation

mc2eqe
Copy link
Contributor

@mc2eqe mc2eqe commented Sep 22, 2023

Pull Request Summary

Check list

  • added or updated unit tests
  • updated Astar official documentation
  • added OnRuntimeUpgrade hook for precompile revert code registration
  • updated spec version
  • updated semver

@mc2eqe mc2eqe added the ci This PR/Issue is related to the topic "CI" label Sep 22, 2023
@mc2eqe
Copy link
Contributor Author

mc2eqe commented Sep 22, 2023

Plan is with this CI update to change the use of custom actions (cancel-workflow-action) and to use built in concurrency.
This will speed up the execution of CI tasks a bit and will not display this additional action job.
It works in a way that stops in-progress jobs or runs for the current workflow if git branch not master.
For master branch it waits previous jobs to finish before starting new ones.

@github-actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
precompiles/batch/src 80% 0%
chain-extensions/types/dapps-staking/src 0% 0%
chain-extensions/types/xvm/src 0% 0%
pallets/contracts-migration/src 0% 0%
chain-extensions/pallet-assets/src 0% 0%
chain-extensions/types/assets/src 0% 0%
pallets/dapps-staking/src/pallet 85% 0%
pallets/dapps-staking/src 81% 0%
precompiles/substrate-ecdsa/src 78% 0%
precompiles/xvm/src 75% 0%
chain-extensions/xvm/src 0% 0%
pallets/custom-signatures/src 51% 0%
pallets/xvm/src 40% 0%
precompiles/utils/src/testing 62% 0%
precompiles/dapps-staking/src 93% 0%
precompiles/utils/macro/src 0% 0%
precompiles/assets-erc20/src 76% 0%
pallets/ethereum-checked/src 48% 0%
precompiles/utils/src 68% 0%
precompiles/xcm/src 84% 0%
pallets/collator-selection/src 69% 0%
chain-extensions/dapps-staking/src 0% 0%
pallets/xc-asset-config/src 53% 0%
primitives/src/xcm 66% 0%
pallets/block-reward/src 85% 0%
pallets/pallet-xcm/src 53% 0%
precompiles/sr25519/src 79% 0%
primitives/src 65% 0%
Summary 57% (2561 / 4490) 0% (0 / 0)

Minimum allowed line rate is 50%

Copy link
Member

@Dinonard Dinonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
Less spam in the jobs section 🙂

One suggestion regarding the description you added - it's better to add it directly into the PR summary. That way it's the first thing user/reviewer sees.

@mc2eqe
Copy link
Contributor Author

mc2eqe commented Sep 25, 2023

Thanks. I'll put next time description in summary.

@mc2eqe mc2eqe merged commit 9395ce0 into master Sep 25, 2023
8 of 9 checks passed
@mc2eqe mc2eqe deleted the fix/concurrency branch September 25, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR/Issue is related to the topic "CI"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants