Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔴 BUG: Navbar light mode text contrast change #248

Open
AshwanthramKL opened this issue Jun 13, 2023 · 12 comments
Open

🔴 BUG: Navbar light mode text contrast change #248

AshwanthramKL opened this issue Jun 13, 2023 · 12 comments
Assignees

Comments

@AshwanthramKL
Copy link
Contributor

Describe the bug
According to color theory, grey and yellow don't go well with each other.

To Reproduce
Steps to reproduce the behavior:

  1. Go to website and observe the navbar

Expected behavior

A better suggestion would be to use the same background color for the text color (white)
Could have something like this.
image

Screenshots
image

Additional context
Add any other context about the problem here.

@ThGnommy
Copy link
Contributor

Hi, there is a discussion about this here
If you have some ideas would be nice :)

@Aswin-Inigo
Copy link

will you assign this work for me... I'll make it better for you!

@ArslanYM
Copy link
Owner

I think @MuhammadRabi is already working on it.

@Aswin-Inigo
Copy link

Okay.. Fine, let me know if @https://github.com/MuhammadRabi need some help..

@MuhammadRabi
Copy link
Contributor

MuhammadRabi commented Jun 15, 2023

I think @MuhammadRabi is already working on it.

@ArslanYM unfortunately, I didn't work on this one, But I opened a related issue #219

@vishalsingh2972
Copy link

@ArslanYM can you assign this to me, want to give it a try!

@ArslanYM
Copy link
Owner

ArslanYM commented Jul 3, 2023

@vishalsingh2972 Sure thing. Assigned to you.

@vishalsingh2972
Copy link

@ArslanYM a small doubt, so as per logic have made the necessary corrections but need help I want to see/check the output of the changes in the frontend. Have never worked with react so can someone please help me with this

@ArslanYM
Copy link
Owner

ArslanYM commented Jul 3, 2023

@vishalsingh2972 If you havent worked with React, how do you plan on solving this issue? This project requires atleast the ground knowledge of React and Tailwind.

@ArslanYM
Copy link
Owner

ArslanYM commented Jul 3, 2023

Here's the development guide : https://github.com/ArslanYM/StarterHive/tree/main/web#readme

@vishalsingh2972
Copy link

@vishalsingh2972 If you haven't worked with React, how do you plan on solving this issue? This project requires atleast the ground knowledge of React and Tailwind.

I apologize for my misunderstanding. Although I haven't worked with React/Tailwind, I have previously solved similar issues using Vanilla JS, so thought of giving this a try!

@kumar2023jha2000
Copy link

Hey If this issue is open I wanted to work on it and I have some doubts that we only have to change the colour on the active link or maybe whenever we hover it will change the colour of never links from grey to White

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants