Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on obsolete ExoPlayer package #1

Open
cybersam opened this issue Nov 9, 2015 · 5 comments
Open

Remove dependency on obsolete ExoPlayer package #1

cybersam opened this issue Nov 9, 2015 · 5 comments

Comments

@cybersam
Copy link

cybersam commented Nov 9, 2015

The RtspExtractor class depends on the com.google.android.exoplayer.source package, which was deleted from ExoPlayer on April 10, 2015 (commit 4c8f9a8).

It should be updated to use com.google.android.exoplayer.FrameworkSampleSource (which is now also deprecated), or ideally com.google.android.exoplayer.extractor.ExtractorSampleSource.

This issue depends on (or may be subsumed by) Issue 2.

@ArnaudCourbiere
Copy link
Owner

Yeah, my goal was to get it to compile with what I had first. Not sure when I'll have time to get around that. Pull request welcome :)

@cybersam
Copy link
Author

Actually, reading the Javadoc for FrameworkSampleSource more closely, it looks like it may be the right subclass to use, despite its deprecation:

Playing container formats for which an ExoPlayer extractor does not yet exist (e.g. ogg) is a valid use case of this class.

@ArnaudCourbiere
Copy link
Owner

Cool, will check it out when I get a chance.
On Nov 25, 2015 1:00 PM, "Sam" [email protected] wrote:

Actually, reading the Javadoc for FrameworkSampleSource more closely, it
looks like it may be the right subclass to use, despite its deprecation:

Playing container formats for which an ExoPlayer extractor does not yet
exist (e.g. ogg) is a valid use case of this class.


Reply to this email directly or view it on GitHub
#1 (comment)
.

@cybersam
Copy link
Author

On the other hand, the Customization section of the ExoPlayer Developer Guide states:

Extractor – If you need to support a container format not currently supported by the ExoPlayer library, consider implementing a custom Extractor class, which can then be used to together with ExtractorSampleSource to play media of that type.

So, it looks like the ideal solution is to create a custom RTSP Extractor that can be used by ExtractorSampleSource.

BTW: I need to be able to play back an "rtsps" stream (i.e., RTSP over TLS), so ideally the RTSP Extractor should support the "rtsp" and "rtsps". This presumably means that the ffmpeg code should be built with the appropriate SSL/TLS options.

@ArnaudCourbiere
Copy link
Owner

for information, I've built the ffmpeg libs using this repo:

https://github.com/cine-io/android-ffmpeg-with-rtmp

Before looking back into building different flavors of the ffmpeg libs I will update ExoPlayer to the latest version and make a simple demo app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants