Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

current is set to Window node after using OS window mode #206

Open
heppocogne opened this issue Sep 29, 2024 · 1 comment · May be fixed by #207
Open

current is set to Window node after using OS window mode #206

heppocogne opened this issue Sep 29, 2024 · 1 comment · May be fixed by #207
Assignees
@worron
Labels
Bug🐞 Something isn't working

Comments

@heppocogne
Copy link

heppocogne commented Sep 29, 2024 •
edited
Loading

Describe the bug
Maybe related to #171.

current variable of interactive shell is set to Window node when using OS window mode.
When this problem happens, the correct current node will be unavailable until current scene is switched, reloaded or the game is restarted.

(note)
I inserted print_debug and found that func _get_valid_root_nodes() -> Array in modules/variable_tracker/module.gd returned:
[@Window@36:<Window#172905991182>, Main:<Node3D#74255959313>, ...]

To Reproduce
Steps to reproduce the behavior:

  1. launch game
  2. open PankuConsole
  3. open any tools in OS window mode
  4. current node is set to Window node

Expected behavior
current should be same as current_scene of game

Screenshots
bug_1
bug_2

Desktop (please complete the following information):

  • OS: Windows 11 Pro
  • Version: 23H2

Additional context
@heppocogne heppocogne changed the title current is overwritten by Window node after using OS window mode current is set to Window node after using OS window mode Sep 29, 2024
@worron worron self-assigned this Sep 29, 2024
@worron worron added the Bug🐞 Something isn't working label Sep 29, 2024
@worron
Copy link
Collaborator

worron commented Sep 29, 2024

Thanks for report. If you need quick temporary solution right now, you can add 'Window' match to panku settings -> variable_tracker -> root_node_exceptions field. We will add os windows to exceptions by default in the future.

@worron worron linked a pull request Sep 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worron worron

Labels
Bug🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore OS window nodes in variable tracker worron/PankuConsole
2 participants
@worron @heppocogne