Skip to content
This repository has been archived by the owner on Feb 17, 2021. It is now read-only.

Remnant default pref in "2019 preview" builds #419

Open
Vangelis66 opened this issue Nov 23, 2019 · 1 comment
Open

Remnant default pref in "2019 preview" builds #419

Vangelis66 opened this issue Nov 23, 2019 · 1 comment

Comments

@Vangelis66
Copy link

Vangelis66 commented Nov 23, 2019

In the 1.7.8.2019.xx.xx builds of CTR, targeting mainly (Classic) Waterfox 56 and official Basilisk 52,

removed the option "add-on manager version number"
Basilisk 2019 and Waterfox don't need this option, because version number is active by default

However, the corresponding (default) pref has been left behind:

pref("extensions.classicthemerestorer.addonversion",true);

but, instead, with a value of false ; the value itself (true | false) is irrelevant here, as the GUI option has been removed from CTR (as per release notes); shouldn't the same apply to the pref itself?

Unless, OTOH, this is still needed to support Firefox v52-56; in any case, it shouldn't apply to Basilisk (because it is present inside Basilisk's about:config tab), should it? ...

Apologies in advance if I have figured things the wrong way...
Best regards 😄

@Aris-t2
Copy link
Owner

Aris-t2 commented Nov 23, 2019

You are right, the pref can be removed as it does not even get monitored but CTRs observers anymore. It does no harm though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants