Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] CustomStamps exports an invalid textColor in case of the default white text color #1064

Open
uwohlfeil opened this issue Jun 4, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@uwohlfeil
Copy link

WebViewer version
10.9.0

The current behavior
When I export the custom stamps as json and import them again, stamps with the default font colour white lose their font colour.

The expected behavior
Exported stamps can be reimported without changes.

Steps to reproduce

Create to Stemps. One with the default white text color and one with another color:

grafik

The JSON looks like this.

[
  {
    "title": "Draft1",
    "subtitle": "[$currentUser] DD/MM/YYYY h:mm A",
    "color": "#4F9964",
    "id": "68a51049-d4c3-2212-ea4f-fe8e4ca6421c",
    "font": "Helvetica",
    "bold": true,
    "italic": false,
    "underline": false,
    "strikeout": false,
    "textColor": { "R": 255, "G": 255, "B": 255, "A": 1 }
  },
  {
    "title": "Draft",
    "subtitle": "[$currentUser] DD/MM/YYYY h:mm A",
    "color": "#2A85D0",
    "id": "06893209-4687-da3b-2713-a53f186d62b8",
    "font": "Helvetica",
    "bold": true,
    "italic": false,
    "underline": false,
    "strikeout": false,
    "textColor": "#ca9999"
  }
]

After I reimport the stamp, the white texted Stamp has an invisible text.

grafik

If I fix the textColor to #FFFFFF, the stamp is correct.

I think, the problem maybe located here:
https://github.com/PDFTron/webviewer-ui/blob/28a787e6ba84cce7c2bcb0de978d2ecd5bf58e4e/.storybook/static/assets/customStamps.js#L84C7-L89C8

@uwohlfeil uwohlfeil changed the title [Bug] [Bug] CustomStamps exports an invalid textColor in case of the default white text color Jun 4, 2024
@bollain bollain self-assigned this Jun 5, 2024
@bollain bollain added the bug Something isn't working label Jun 19, 2024
@bollain
Copy link
Collaborator

bollain commented Jun 19, 2024

Hi @uwohlfeil - thanks for the report. When this gets fixed we will let you know so you can pull the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants