Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STYLE_bug] When styling does not find a box::use, all lines are converted into NA #134

Open
radbasa opened this issue Aug 21, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@radbasa
Copy link
Collaborator

radbasa commented Aug 21, 2024

          @jakubnowicki Will need to go back to `box.linters::style_*`.

0.10.2 converts:

# View: Shiny modules and related code.
# https://go.appsilon.com/rhino-project-structure

to

NA
NA

Originally posted by @radbasa in Appsilon/rhino#607 (comment)

@radbasa
Copy link
Collaborator Author

radbasa commented Aug 21, 2024

We can do either of two things:

  1. Implement and activate the exclude_files parameter of box.linters::style_box_use_dir()
  2. Fix the bug converting the comment-only file to NA.

@radbasa radbasa changed the title @jakubnowicki Will need to go back to box.linters::style_*. [STYLE_bug] styling removes all comments from comments-only files Aug 21, 2024
@radbasa radbasa self-assigned this Aug 21, 2024
@radbasa radbasa added the bug Something isn't working label Aug 21, 2024
@radbasa radbasa changed the title [STYLE_bug] styling removes all comments from comments-only files [STYLE_bug] When styling does not find a box::use, all lines are converted into NA Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant