Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fails on linkcheck #68

Open
probonopd opened this issue Nov 14, 2021 · 5 comments
Open

CI fails on linkcheck #68

probonopd opened this issue Nov 14, 2021 · 5 comments
Assignees

Comments

@probonopd
Copy link
Member

CI fails on linkcheck, what does this want to tell me?
I did not even touch any links in my commit.

https://github.com/AppImage/docs.appimage.org/runs/4202987393?check_suite_focus=true

@TheAssassin
Copy link
Member

CI has always failed the linkcheck test. Mostly because old articles ported from those Wiki pages contained broken links. Please don't hesitate to send a PR fixing those links.

https://www.writethedocs.org/guide/tools/testing/

@probonopd
Copy link
Member Author

Actually I just want the word "banner" to be replaced with the word "button" without caring about anything else on that page. But apparently my change does not get applied to https://docs.appimage.org/packaging-guide/distribution.html?highlight=button#download-as-an-appimage-banner, because there is still "banner".

Stuff like this makes this repository so cumbersome in comparison to GitHub Wiki.

@TheAssassin
Copy link
Member

This is completely off topic, though. You asked about the linkcheck.

The deployment is not organized within GitHub Actions, because that system is not designed for such tasks. The repository will eventually be deployed by my CI service. As I have been upgrading services, it might take a little longer today.

@probonopd
Copy link
Member Author

I assumed that the GitHub Action does everything, and if the GitHub Action fails, then no deployment takes place. No hurries. This is not urgent, I just wanted to understand why the change was not reflected. Thanks!

@TheAssassin
Copy link
Member

Please feel free to ping me next time. I didn't notice the delay either. One can have a lot of monitoring and still miss a few occasions a year...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants