Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed css of service page #848

Closed
wants to merge 0 commits into from
Closed

Conversation

dhairyagothi
Copy link
Contributor

@dhairyagothi dhairyagothi commented Jul 13, 2024

Description

[Please include a brief description of the changes or features added]

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jul 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 6:50am

Copy link

netlify bot commented Jul 13, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 0560c26
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/669cf035b9b356000981c9c7
😎 Deploy Preview https://deploy-preview-848--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @dhairyagothi! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@varshith257
Copy link
Collaborator

varshith257 commented Jul 13, 2024

@dhairyagothi Can you move Get started and contact us pages to centre? everything is fine except above and looks good to merge

@dhairyagothi
Copy link
Contributor Author

image

@varshith257 have a look on it

@varshith257
Copy link
Collaborator

@dhairyagothi Can you see at netifly deploy , their view of page got rendered two times check it out and in website view the image should be beside the section text

@dhairyagothi
Copy link
Contributor Author

@varshith257 done please check and merge PR asap

@dhairyagothi
Copy link
Contributor Author

@varshith257 please have a look

@dhairyagothi
Copy link
Contributor Author

@varshith257 please merge PR

@dhairyagothi
Copy link
Contributor Author

please merge PR @varshith257

@varshith257
Copy link
Collaborator

varshith257 commented Jul 18, 2024

Hey! I got busy with exams. And I follow up with the other contributers review of this PR for time being.

@Pruthaa17 @Anjaliavv51 @aditya-bhaumik Can you look at the PR changes are good at mobile and web view? If needed request changes in the PR or approve the PR

@aditya-bhaumik
Copy link
Contributor

aditya-bhaumik commented Jul 18, 2024

@dhairyagothi @varshith257 hi i think everything is fine except 2 things the navbar should be similar to the main page navbar
image
image

as it is same in all the pages except this page the elements can be different but the color scheme should be similar

image

also the page is overflowing in small devices rest everything is good

@dhairyagothi
Copy link
Contributor Author

hey @aditya-bhaumik i am also from vit bhopal 😂

@Anjaliavv51
Copy link
Contributor

Anjaliavv51 commented Jul 18, 2024

@dhairyagothi u have removed id names in footer , which is used to Reveal elements on scroll

please undo those changes.

@dhairyagothi
Copy link
Contributor Author

okay i will do changes @aditya-bhaumik @Anjaliavv51

@Anjaliavv51
Copy link
Contributor

Anjaliavv51 commented Jul 18, 2024

@dhairyagothi

image

please minimize the dimensions of Make an Appointmnet section.

Only that's the issue remaining all are perfect.

@Anjaliavv51
Copy link
Contributor

@dhairyagothi please check the mentioned changes.

@dhairyagothi
Copy link
Contributor Author

@dhairyagothi please check the mentioned changes.

ok i will do asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Fixing Complete CSS of Delivery page
4 participants