From fbf00e474df67e3faeffc8cdf2d7a29ec867b1df Mon Sep 17 00:00:00 2001
From: Divyansh Agrawal <57246976+DivyanshByte@users.noreply.github.com>
Date: Sun, 16 Jun 2024 22:22:41 +0530
Subject: [PATCH] Added Option to Disable Logging By Default (#474)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Added Option to Disable Logging By Default

* Added Userscript Support to Disable Logging

* Formatting and Fixed Compiling

* Updated Description of Setting Option

* Whitespace 😅

* Dot in Description of Setting option

* Typo in JAVASCRIPT
---
 .../UserScript/Return Youtube Dislike.user.js |  7 +++++--
 Extensions/combined/popup.html                |  6 +++++-
 Extensions/combined/popup.js                  | 21 ++++++++++++++++++-
 Extensions/combined/ryd.background.js         | 17 +++++++++++++++
 Extensions/combined/src/state.js              | 12 +++++++++++
 Extensions/combined/src/utils.js              | 12 ++++++-----
 6 files changed, 66 insertions(+), 9 deletions(-)

diff --git a/Extensions/UserScript/Return Youtube Dislike.user.js b/Extensions/UserScript/Return Youtube Dislike.user.js
index 05ba6fd4..2bb961c2 100644
--- a/Extensions/UserScript/Return Youtube Dislike.user.js	
+++ b/Extensions/UserScript/Return Youtube Dislike.user.js	
@@ -28,6 +28,7 @@ const extConfig = {
   // You may change the following variables to allowed values listed in the corresponding brackets (* means default). Keep the style and keywords intact.
   showUpdatePopup: false, // [true, false*] Show a popup tab after extension update (See what's new)
   disableVoteSubmission: false, // [true, false*] Disable like/dislike submission (Stops counting your likes and dislikes)
+  disableLogging: true, // [true*, false] Disable Logging API Response in JavaScript Console.
   coloredThumbs: false, // [true, false*] Colorize thumbs (Use custom colors for thumb icons)
   coloredBar: false, // [true, false*] Colorize ratio bar (Use custom colors for ratio bar)
   colorTheme: "classic", // [classic*, accessible, neon] Color theme (red/green, blue/yellow, pink/cyan)
@@ -51,8 +52,10 @@ let isMobile = location.hostname == "m.youtube.com";
 let isShorts = () => location.pathname.startsWith("/shorts");
 let mobileDislikes = 0;
 function cLog(text, subtext = "") {
-  subtext = subtext.trim() === "" ? "" : `(${subtext})`;
-  console.log(`[Return YouTube Dislikes] ${text} ${subtext}`);
+  if (!extConfig.disableLogging) {
+    subtext = subtext.trim() === "" ? "" : `(${subtext})`; 
+    console.log(`[Return YouTube Dislikes] ${text} ${subtext}`); 
+  }
 }
 
 function isInViewport(element) {
diff --git a/Extensions/combined/popup.html b/Extensions/combined/popup.html
index 538958db..450c10f5 100644
--- a/Extensions/combined/popup.html
+++ b/Extensions/combined/popup.html
@@ -84,7 +84,6 @@ <h1 style="margin-bottom: 0.75rem" title="__MSG_extensionName__">
         />
       </svg>
     </button>
-
     <!-- bottom-right -->
     <div id="ext">
       <a
@@ -104,6 +103,11 @@ <h1 style="margin-bottom: 0.75rem" title="__MSG_extensionName__">
           __MSG_textSettings__
         </span>
       </label>
+      <label class="switch" data-hover="Disable Logging API Response in JavaScript Console.">
+        <input type="checkbox" id="disable_logging"/>
+        <span class="slider"/>
+        <span class="switchLabel">Disable logging to console</span>
+      </label>
       <br />
       <label class="switch" data-hover="__MSG_reformatLikesHover__">
         <input type="checkbox" id="number_reformat_likes" />
diff --git a/Extensions/combined/popup.js b/Extensions/combined/popup.js
index 09be9304..2fd52975 100644
--- a/Extensions/combined/popup.js
+++ b/Extensions/combined/popup.js
@@ -4,6 +4,7 @@ import { cLog } from "./src/utils";
 const config = {
   advanced: false,
   disableVoteSubmission: false,
+  disableLogging: true,
   coloredThumbs: false,
   coloredBar: false,
   colorTheme: "classic",
@@ -15,7 +16,6 @@ const config = {
     '<svg xmlns="http://www.w3.org/2000/svg" enable-background="new 0 0 24 24" height="24px" viewBox="0 0 24 24" width="24px" fill="currentColor"><rect fill="none" height="24" width="24"/><path d="M19.5,12c0-0.23-0.01-0.45-0.03-0.68l1.86-1.41c0.4-0.3,0.51-0.86,0.26-1.3l-1.87-3.23c-0.25-0.44-0.79-0.62-1.25-0.42 l-2.15,0.91c-0.37-0.26-0.76-0.49-1.17-0.68l-0.29-2.31C14.8,2.38,14.37,2,13.87,2h-3.73C9.63,2,9.2,2.38,9.14,2.88L8.85,5.19 c-0.41,0.19-0.8,0.42-1.17,0.68L5.53,4.96c-0.46-0.2-1-0.02-1.25,0.42L2.41,8.62c-0.25,0.44-0.14,0.99,0.26,1.3l1.86,1.41 C4.51,11.55,4.5,11.77,4.5,12s0.01,0.45,0.03,0.68l-1.86,1.41c-0.4,0.3-0.51,0.86-0.26,1.3l1.87,3.23c0.25,0.44,0.79,0.62,1.25,0.42 l2.15-0.91c0.37,0.26,0.76,0.49,1.17,0.68l0.29,2.31C9.2,21.62,9.63,22,10.13,22h3.73c0.5,0,0.93-0.38,0.99-0.88l0.29-2.31 c0.41-0.19,0.8-0.42,1.17-0.68l2.15,0.91c0.46,0.2,1,0.02,1.25-0.42l1.87-3.23c0.25-0.44,0.14-0.99-0.26-1.3l-1.86-1.41 C19.49,12.45,19.5,12.23,19.5,12z M12.04,15.5c-1.93,0-3.5-1.57-3.5-3.5s1.57-3.5,3.5-3.5s3.5,1.57,3.5,3.5S13.97,15.5,12.04,15.5z"/></svg>',
   hideAdvancedMessage:
     '<svg xmlns="http://www.w3.org/2000/svg" height="24px" viewBox="0 0 24 24" width="24px" fill="currentColor"><path d="M0 0h24v24H0V0z" fill="none" opacity=".87"/><path d="M12 2C6.47 2 2 6.47 2 12s4.47 10 10 10 10-4.47 10-10S17.53 2 12 2zm4.3 14.3c-.39.39-1.02.39-1.41 0L12 13.41 9.11 16.3c-.39.39-1.02.39-1.41 0-.39-.39-.39-1.02 0-1.41L10.59 12 7.7 9.11c-.39-.39-.39-1.02 0-1.41.39-.39 1.02-.39 1.41 0L12 10.59l2.89-2.89c.39-.39 1.02-.39 1.41 0 .39.39.39 1.02 0 1.41L13.41 12l2.89 2.89c.38.38.38 1.02 0 1.41z"/></svg>',
-
   links: {
     website: "https://returnyoutubedislike.com",
     github: "https://github.com/Anarios/return-youtube-dislike",
@@ -68,6 +68,10 @@ document
     chrome.storage.sync.set({ disableVoteSubmission: ev.target.checked });
   });
 
+document.getElementById("disable_logging").addEventListener("click", (ev) => {
+  chrome.storage.sync.set({ disableLogging:ev.target.checked })
+});
+
 document.getElementById("colored_thumbs").addEventListener("click", (ev) => {
   chrome.storage.sync.set({ coloredThumbs: ev.target.checked });
 });
@@ -124,6 +128,7 @@ initConfig();
 
 function initConfig() {
   initializeDisableVoteSubmission();
+  initializeDisableLogging();
   initializeVersionNumber();
   initializeColoredThumbs();
   initializeColoredBar();
@@ -178,6 +183,12 @@ function initializeDisableVoteSubmission() {
   });
 }
 
+function initializeDisableLogging(){
+  chrome.storage.sync.get(['disableLogging'], (res) => {
+    handleDisableLoggingChangeEvent(res.disableLogging);
+  });
+}
+
 function initializeColoredThumbs() {
   chrome.storage.sync.get(["coloredThumbs"], (res) => {
     handleColoredThumbsChangeEvent(res.coloredThumbs);
@@ -239,6 +250,9 @@ function storageChangeHandler(changes, area) {
       changes.disableVoteSubmission.newValue,
     );
   }
+  if (changes.disableLogging !== undefined) {
+    handleDisableLoggingChangeEvent(changes.disableLogging.newValue);
+  }
   if (changes.coloredThumbs !== undefined) {
     handleColoredThumbsChangeEvent(changes.coloredThumbs.newValue);
   }
@@ -268,6 +282,11 @@ function handleDisableVoteSubmissionChangeEvent(value) {
   document.getElementById("disable_vote_submission").checked = value;
 }
 
+function handleDisableLoggingChangeEvent(value) {
+  config.disableLogging = value;
+  document.getElementById("disable_logging").checked = value;
+}
+
 function handleColoredThumbsChangeEvent(value) {
   config.coloredThumbs = value;
   document.getElementById("colored_thumbs").checked = value;
diff --git a/Extensions/combined/ryd.background.js b/Extensions/combined/ryd.background.js
index d9ddb2d8..07752305 100644
--- a/Extensions/combined/ryd.background.js
+++ b/Extensions/combined/ryd.background.js
@@ -6,6 +6,7 @@ let api;
 /** stores extension's global config */
 let extConfig = {
   disableVoteSubmission: false,
+  disableLogging: true,
   coloredThumbs: false,
   coloredBar: false,
   colorTheme: "classic", // classic, accessible, neon
@@ -275,6 +276,8 @@ function storageChangeHandler(changes, area) {
       changes.numberDisplayReformatLikes.newValue,
     );
   }
+  if (changes.disableLogging !== undefined) {
+    handleDisableLoggingChangeEvent(changes.disableLogging.newValue);
   if (changes.showTooltipPercentage !== undefined) {
     handleShowTooltipPercentageChangeEvent(
       changes.showTooltipPercentage.newValue,
@@ -296,6 +299,9 @@ function handleDisableVoteSubmissionChangeEvent(value) {
   }
 }
 
+function handleDisableLoggingChangeEvent(value) {
+  extConfig.disableLogging = value;
+}
 function handleNumberDisplayFormatChangeEvent(value) {
   extConfig.numberDisplayFormat = value;
 }
@@ -342,6 +348,7 @@ api.storage.onChanged.addListener(storageChangeHandler);
 
 function initExtConfig() {
   initializeDisableVoteSubmission();
+  initializeDisableLogging();
   initializeColoredThumbs();
   initializeColoredBar();
   initializeColorTheme();
@@ -362,6 +369,16 @@ function initializeDisableVoteSubmission() {
   });
 }
 
+function initializeDisableLogging(){
+  api.storage.sync.get(['disableLogging'],(res)=>{
+    if (res.disableLogging === undefined) {
+      api.storage.sync.set({disableLogging:true});
+    }
+    else {
+      extConfig.disableLogging = res.disableLogging;
+    }
+  });
+}
 function initializeColoredThumbs() {
   api.storage.sync.get(["coloredThumbs"], (res) => {
     if (res.coloredThumbs === undefined) {
diff --git a/Extensions/combined/src/state.js b/Extensions/combined/src/state.js
index 662272e9..47b6cafb 100644
--- a/Extensions/combined/src/state.js
+++ b/Extensions/combined/src/state.js
@@ -25,6 +25,7 @@ const NEUTRAL_STATE = "NEUTRAL_STATE";
 
 let extConfig = {
   disableVoteSubmission: false,
+  disableLogging: true,
   coloredThumbs: false,
   coloredBar: false,
   colorTheme: "classic",
@@ -298,6 +299,7 @@ async function setInitialState() {
 
 async function initExtConfig() {
   initializeDisableVoteSubmission();
+  initializeDisableLogging();
   initializeColoredThumbs();
   initializeColoredBar();
   initializeColorTheme();
@@ -332,6 +334,16 @@ function initializeDisableVoteSubmission() {
   });
 }
 
+function initializeDisableLogging() {
+  getBrowser().storage.sync.get(["disableLogging"], (res) => {
+    if (res.disableLogging === undefined) {
+      getBrowser().storage.sync.set({ disableLogging: true });
+    } else {
+      extConfig.disableLogging = res.disableLogging;
+    }
+  });
+}
+
 function initializeColoredThumbs() {
   getBrowser().storage.sync.get(["coloredThumbs"], (res) => {
     if (res.coloredThumbs === undefined) {
diff --git a/Extensions/combined/src/utils.js b/Extensions/combined/src/utils.js
index 60a9af64..cf5be6cb 100644
--- a/Extensions/combined/src/utils.js
+++ b/Extensions/combined/src/utils.js
@@ -103,11 +103,13 @@ function isVideoLoaded() {
 }
 
 function cLog(message, writer) {
-  message = `[return youtube dislike]: ${message}`;
-  if (writer) {
-    writer(message);
-  } else {
-    console.log(message);
+  if (!extConfig.disableLogging){
+    message = `[return youtube dislike]: ${message}`;
+    if (writer) {
+      writer(message);
+    } else {
+      console.log(message);
+    }
   }
 }