Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Inspect Data" (ALT - D) should work on textures #206

Open
emackey opened this issue Jan 18, 2021 · 1 comment
Open

"Inspect Data" (ALT - D) should work on textures #206

emackey opened this issue Jan 18, 2021 · 1 comment

Comments

@emackey
Copy link
Member

emackey commented Jan 18, 2021

Currently it works on "images", but not "textures". We should look up the image associated with a texture.

Might also be good for it to work on texture sources inside materials, if possible.

@emackey
Copy link
Member Author

emackey commented Jan 18, 2021

Come to think of it, "Go to Definition" could actually open an image, for PNGs and JPGs at least, instead of running the image viewer webview, if that helps streamline the behavior of peek etc. "Inspect" would be different from "Go to" then.

On the language server definition provider side, this would mean returning a location that pointed at the image's actual file URI, rather than returning the internal gltf-dataUri reference. Would the behavior be better? This wouldn't work for KTX2, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant