Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer Extension crashes when file is changed externally #175

Open
hybridherbst opened this issue Dec 20, 2019 · 2 comments
Open

Viewer Extension crashes when file is changed externally #175

hybridherbst opened this issue Dec 20, 2019 · 2 comments

Comments

@hybridherbst
Copy link

Every time I overwrite the GLTF + accompanying GLB and texture files from an external application, the GLTF properly updates in Code but the Extension Host crashes. I need to restart the extension host and click "preview" again to get the model preview.

Expected: external update and re-focussing Code updates the preview
Actual: eternal update and re-focussing Code crashes the extension host

@emackey
Copy link
Member

emackey commented Dec 20, 2019

I wonder if too many auto-updates are coming through at once. Maybe adding a debounce to the updater would calm things down.

@hybridherbst
Copy link
Author

hybridherbst commented Dec 20, 2019

Might well be, I think when I export basically all files change at once (gltf, bin, all textures), or in very short succession after each other (as the files are written).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants