Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tracking] AIP#61 - AdEx v5: significantly cheaper channels #338

Open
2 of 26 tasks
elpiel opened this issue Mar 8, 2021 · 0 comments
Open
2 of 26 tasks

[tracking] AIP#61 - AdEx v5: significantly cheaper channels #338

elpiel opened this issue Mar 8, 2021 · 0 comments
Assignees
Milestone

Comments

@elpiel
Copy link
Member

elpiel commented Mar 8, 2021

Tracking issue for the changes regarding AIP#61: AdEx v5: significantly cheaper channels (full details here)

  • Adapter
  • Channel & Campaign AIP #61 v5: Channel and Campaign #341
  • NewState & Accounting
  • Sentry
    • Accounting & spenders
    • GET /channel/:id/spender/:addr
    • GET /channel/:id/spender/all
    • POST /channel/:id/spender/:addr
    • POST /channel/:id/pay (Channel Payout with authentication of the spender)
      Withdrawals of advertiser funds - re-introduces the PAY event with a separate route
    • GET /channel/:id/get-leaf
      from AIP#61:

      add another helper route /get-leaf that is called like this: /get-leaf?spender=... or /get-leaf?earner=...; this will get the latest approved state (NewState/ApproveState pair), will find the given spender/earner in the balances tree, and produce a merkle proof for it; this is useful for the Platform to verify if a spender leaf really exists

    • POST /campaign/:id/close (newBudget = totalSpent, i.e. newBudget = oldBudget - remaining)
    • POST / PUT /campaign (create / modify)
      • also update spender available funds when they try to mutate campaigns

    • Enforce limits
    • Events
      • enforce per-campaign spending limits atomically
      • update the spenderLeaf directly in the DB when we receive an authenticated ApproveState/NewState

    • Distribute fees
    • Analytics breakdowns by 1hr
  • Validator
  • remove old routes and remove V5 suffixes from var names (eg analyticsRouterV5 -> analyticsRouter); do not remove the /v5 prefix from the routes themselves
@Ivshti Ivshti pinned this issue Mar 10, 2021
@Ivshti Ivshti added this to the v0.15.0 milestone Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants