Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to return data for multiple earners #311

Closed
wants to merge 2 commits into from
Closed

add ability to return data for multiple earners #311

wants to merge 2 commits into from

Conversation

samparsky
Copy link
Contributor

Fixes #295

@samparsky samparsky requested a review from Ivshti August 10, 2020 10:12
Ivshti
Ivshti requested changes Nov 12, 2020
View reviewed changes
Copy link
Member

@Ivshti Ivshti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. no API compatibility - we can't just break older args that are used (earner)
  2. look into whether it will be more efficient to do this through the mongo qurey itself
    if the code would become very complicated then perhaps maybe it's not worth it

routes/analytics.js
const channelsList = channels.split(',')
if (earnersList && earnersList.length > 1) {
const earnersData = await Promise.all(
earnersList.map(earner => analytics(req, channelsList, earner))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did we decide to NOT do this through the mongo query?

@samparsky samparsky closed this Feb 22, 2021
@Ivshti
Copy link
Member

Ivshti commented Mar 10, 2021 •
edited
Loading

@samparsky why was this closed? did you look into how to do it with a mongo query

unless you're gonna rework into a new PR, let's keep this open

@Ivshti Ivshti reopened this Mar 10, 2021
@Ivshti
Copy link
Member

Ivshti commented Jul 1, 2021

will be obsolete cause of the V5 analytics

@Ivshti Ivshti closed this Jul 1, 2021
@Ivshti Ivshti mentioned this pull request Jul 5, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivshti Ivshti Ivshti requested changes

@ivopaunov ivopaunov Awaiting requested review from ivopaunov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

analytics: ability to return data for multiple earners with admin analytics
2 participants
@samparsky @Ivshti