feat(github-actions): support npm for audit action #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
fpaul-1A
force-pushed
the
feat/audit-npm
branch
from
712addf
to
2c009f3
Compare
cpaulve-1A
reviewed
Oct 17, 2024
cpaulve-1A
reviewed
Oct 17, 2024
fpaul-1A
force-pushed
the
feat/audit-npm
branch
2 times, most recently
from
7de1f97
to
03e4ceb
Compare
kpanot
reviewed
Oct 17, 2024
fpaul-1A
force-pushed
the
feat/audit-npm
branch
2 times, most recently
from
95330bd
to
b052bf7
Compare
kpanot
reviewed
Oct 17, 2024
fpaul-1A
force-pushed
the
feat/audit-npm
branch
from
b052bf7
to
9a8df69
Compare
cpaulve-1A
reviewed
Oct 18, 2024
| return { highestSeverityFound, nbVulnerabilities }; | ||
| } | ||
|
|
||
| function updateReportWithVulnerability(currentReport: OtterAuditReport, severityThreshold: Severity, vulnerability: OtterAdvisory): OtterAuditReport { |
There was a problem hiding this comment.
Do you think it makes sense to also update the highest vulnerability found here?
(and no handle it in a separate loop ?)
There was a problem hiding this comment.
it is only needed for Yarn4 because it doesn't provide a summary
The loop to find the highest severity actually loops only over 5 elements, it's not the same loop as the one on the list of vulnerabilities
So no, I don't think there is any reason not to trust the summary and compute the highest severity on our own
matthieu-crouzet
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Related issues