Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: yarn create not working for Yarn 1.* #1189

Open
2 of 3 tasks
kpanot opened this issue Jan 5, 2024 · 1 comment · Fixed by #1216 · May be fixed by #1230
Open
2 of 3 tasks

[Bug]: yarn create not working for Yarn 1.* #1189

kpanot opened this issue Jan 5, 2024 · 1 comment · Fixed by #1216 · May be fixed by #1230
Assignees
@vscaiceanu-1a
Labels
bug Something isn't working priority:high
Milestone
On boarding impro...

Comments

@kpanot
Copy link
Contributor

kpanot commented Jan 5, 2024 •
edited
Loading

Package name

core, create, schematics, workspace

Package version

10.0.0

Reproduction steps

Execute the command yarn create @o3r my-app with yarn version 1.22.0

Current result

Error of requesting -w for package installed at workspace level.

Expected result

Additional comments

No response
@kpanot kpanot added the bug Something isn't working label Jan 5, 2024
@kpanot kpanot added this to the On boarding improvement milestone Jan 5, 2024
@vscaiceanu-1a vscaiceanu-1a self-assigned this Jan 15, 2024
@kpanot kpanot mentioned this issue Jan 15, 2024
Closed
@vscaiceanu-1a vscaiceanu-1a mentioned this issue Jan 15, 2024
Merged
vscaiceanu-1a added a commit that referenced this issue Jan 16, 2024
@vscaiceanu-1a
fix(schematics): o3r create command not working for yarn 1 (#1216)
ee6ac0b 
## Proposed change

<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that is required for this change. -->

## Related issues

- 🐛 Fixes #1189

## Explanation

In `@o3r/workspace` ng-add script, `addWorkspacesToProject` is adding
the `workspaces` field to the root `package.json`.
We should execute this step last, after adding all other dependencies,
otherwise yarn gets confused and doesn't know where to add the
dependencies (to the root or to a workspace).
@vscaiceanu-1a vscaiceanu-1a linked a pull request Mar 8, 2024 that will close this issue
Open
@vscaiceanu-1a vscaiceanu-1a linked a pull request Mar 8, 2024 that will close this issue
feat(it-tests): test schematics with yarn 1 #1230
Open
@pginoux-1A
Copy link
Contributor

pginoux-1A commented Apr 30, 2024 •
edited by mrednic-1A
Loading

Work left to do : We recommand to use npm create, add "yarn create" limitation in the doc as known issues (there is only one .bin/create script on global and when multiple create packages the latest installed will be kept for create comamnd). Merge the PR #1230.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vscaiceanu-1a vscaiceanu-1a

Labels
bug Something isn't working priority:high
Projects
None yet
Milestone
On boarding improvement
3 participants
@kpanot @vscaiceanu-1a @pginoux-1A