Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify exports for services, transitions and utils #867

Open
5 tasks
quentinderoubaix opened this issue Jul 25, 2024 · 1 comment · May be fixed by #876
Open
5 tasks

Simplify exports for services, transitions and utils #867

quentinderoubaix opened this issue Jul 25, 2024 · 1 comment · May be fixed by #876
Assignees
Milestone

Comments

@quentinderoubaix
Copy link
Contributor

quentinderoubaix commented Jul 25, 2024

Context
Currently our exports enforce users to import services, transitions and utils like the following:

import {createResizeObserver} from '@agnos-ui/svelte-bootstrap/services/resizeObserver';
// or
import {createResizeObserver} from '@agnos-ui/svelte-bootstrap';

We now judge thiat is a bit overkill and propose to separate only in main sub-areas, resulting in:

import {createResizeObserver} from '@agnos-ui/svelte-bootstrap/services';

Work involved

  • update packages exports + add new index.ts in the required folders
  • update internal imports (could be done automatically through the eslint plugin)
  • potentially update the eslint plugin
  • potentially update the script generateExports.js
  • udpate the informative alert of the typedoc pages
@quentinderoubaix
Copy link
Contributor Author

Requires further discussion, the Draft PR has not been deemed satisfiable yet.

@quentinderoubaix quentinderoubaix modified the milestones: v0.5, v0.6 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment