Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caliper config header logic fix #1369

Open
cyrush opened this issue Aug 26, 2024 · 2 comments
Open

caliper config header logic fix #1369

cyrush opened this issue Aug 26, 2024 · 2 comments
Labels

Comments

@cyrush
Copy link
Member

cyrush commented Aug 26, 2024

ascent_config.h.in:

#cmakedefine ASCENT_CALIPER_ENABLED   "@ASCENT_CALIPER_ENABLED@"

Should be:

#cmakedefine ASCENT_CALIPER_ENABLED   "@CALIPER_FOUND@"
@cyrush cyrush added the bug label Aug 26, 2024
@cyrush
Copy link
Member Author

cyrush commented Aug 26, 2024

@nicolemarsaglia related to the issue you saw in your caliper work, this is how we should fix the define.

@nicolemarsaglia
Copy link
Contributor

Ah that makes sense! Thank you for double checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants