Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#28 alternate means of transport #178

Open
wants to merge 4 commits into
base: staging
Choose a base branch
from

Conversation

n-sheikh
Copy link
Contributor

No description provided.

Copy link
Owner

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 user stories implemented in this PR, you should separate them.
Issues:
The directions are on the top, so once you select a walking method, you can’t change it (ex: walking to driving), also once the directions show up you can’t dismiss it. The styling of the directions aren’t really done. There are no indoor directions. The commits aren't linked to the issue

Comment on lines +1 to +3

REACT_APP_GOOGLE_DIRECTIONS_API_KEY=AIzaSyDpY_ACPWoo3mVPPmiLKQe1aBhjkDYlwJI
REACT_APP_GOOGLE_PLACES_API=AIzaSyCYIXGJomGdZcisqVNfYmgoavLix_-AgOw
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be committed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants