Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of input stream error #6

Open
ghost opened this issue Dec 8, 2010 · 2 comments
Open

Handling of input stream error #6

ghost opened this issue Dec 8, 2010 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 8, 2010

I am new to Objective C and your streaming XML parser, but I ran into problem when network error occurs. I wanted to know if this is correct:
In AQXMLParser.m at line 963:
_internal->error = [input streamError];

Should this be:
_internal->error = [[input streamError] retain];

When this error occurs, then the parser is released, I get a crash in -dealloc at the line:
[_internal->error release];

with this error message:
-[CFError release]: message sent to deallocated instance

@AlanQuatermain
Copy link
Owner

Yes, good catch— it should indeed be retained. I'll tweak it and push the changes. In fact, I think there might be some other similar changes in the Kobo app to move across.

@marcusramberg
Copy link

Funny. I just fixed this error in our app and was about to report it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants