Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] Migrate to patch based system #231

Open
6 tasks done
ghost opened this issue Aug 19, 2022 · 9 comments
Open
6 tasks done

[1.12.2] Migrate to patch based system #231

ghost opened this issue Aug 19, 2022 · 9 comments
Assignees
Labels
accepted True. core-team-work enhancement New feature or request

Comments

@ghost
Copy link

ghost commented Aug 19, 2022

For better code organization and compatibility, migrating mixin to a patch based system should be a good try.
I'm already working on this and it seems to be easy for me.

Things to be merged

  • Bootstrap part
  • Core part
  • CPS part
  • NSC part
  • Optimization part
  • Realtime part
@josephworks josephworks assigned ghost Aug 19, 2022
@josephworks josephworks added enhancement New feature or request accepted True. core-team-work labels Aug 19, 2022
@ghost
Copy link
Author

ghost commented Aug 20, 2022

When migrating I've found several codes that aren't or may not be good ( or safe ). These parts will be listed below:

  1. bootstrap/DummyEula.java removed eula checking which I think is not ok.
  2. cps/MixinChunkProviderServer.java tried to directly remove a chunk without nulling lastChunkByPos which is defined in Paper 0087-Optimize-Chunk-Access.patch. Is that safe to do so?

@josephworks
Copy link
Member

I am not sure about number 2, but I agree with you on number 1.

Is EULA checking removed in our current codebase? If so, can you readd it?

@ghost
Copy link
Author

ghost commented Aug 26, 2022

Almost done! :)
I've readded EULA, too :)

@josephworks
Copy link
Member

There was a merge to master two days ago. Please be sure to apply those changes as you see fit before your PR.

Thank you so much for your work, and let me know if you need anything!

@josephworks josephworks self-assigned this Aug 30, 2022
@ghost
Copy link
Author

ghost commented Sep 1, 2022

Well it seems craftbukkit has already included some realtime fixes, for example in EntityItem.java.
it's ok to keep them but I think overriding with akarin's code will be better.

@ghost
Copy link
Author

ghost commented Sep 1, 2022

Seems that akarin's code base is pretty old now, some mixins are actually conflict with recent craftbukkit changes. lol

@ghost
Copy link
Author

ghost commented Sep 1, 2022

All codes are done :)
I'm going to prepare the build system, double-check the patches and do some clean up job :)

@ghost
Copy link
Author

ghost commented Sep 28, 2022

@josephworks I'm not so familiar with shell so I'm not so clear how to make the ./akarin work. It would be great that if you can help.
I've now finished most of the cleanup job, I'll upload the patches soon :)

@josephworks
Copy link
Member

@siyy123 Sorry for the late response. We can definitely look into getting an ./akarin script to work in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted True. core-team-work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant