Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] JDK 9+ support? #220

Open
ghost opened this issue May 4, 2022 · 17 comments
Open

[1.12.2] JDK 9+ support? #220

ghost opened this issue May 4, 2022 · 17 comments
Assignees
Labels
1.12.2 This issue was found in version 1.12.2 accepted True. enhancement New feature or request

Comments

@ghost
Copy link

ghost commented May 4, 2022

When launching akarin-1.12.2-0.4.2 on jdk 9+ (in my case jdk11) the server will crash.
latest.log
Maybe we could update the mixin to solve the problem?

@dani31c
Copy link

dani31c commented Jul 21, 2022

Why using Java 8 in 1.12.2 tho?

@dani31c
Copy link

dani31c commented Jul 21, 2022

Most plugins for 1.12.2 wont work with it

@ghost
Copy link
Author

ghost commented Jul 22, 2022

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

@dani31c
Copy link

dani31c commented Jul 22, 2022

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

Well, mixin could be updated for 1.12.2, but there is really no point; Most of the plugins won't work past jre/jdk 8, and 1.12.2 itself was designed for jre/jdk 8, so doing that would still be quite unnecesary nowadays, you'll find no benefit on updating mixin for it

@ghost
Copy link
Author

ghost commented Jul 22, 2022

Why using Java 8 in 1.12.2 tho?

Currently akarin uses launchwrapper and mixin 0.7 for code injection which don't support jdk 9+.

Well, mixin could be updated for 1.12.2, but there is really no point; Most of the plugins won't work past jre/jdk 8, and 1.12.2 itself was designed for jre/jdk 8, so doing that would still be quite unnecesary nowadays, you'll find no benefit on updating mixin for it

Supporting jdk 9+ will be backward compatible and you can still run it with jdk 8 if your plugins don't support. Using higher version of jdk will give better gc, jit, and more cpu features.
Actually vanilla and paper are both compiled in java 8 but can also run on jdk 9+ and many plugins are in fact designed for both 1.12- and 1.13+, common plugins designed specifically for 1.12 and java8 actually runs fine with latest java.

@WesleyVanNeck
Copy link
Member

will try to get support for java 9 and up soonish

@josephworks
Copy link
Member

@siyy123 @LegacyGamerHD What is the status on this?

@josephworks josephworks added 1.12.2 This issue was found in version 1.12.2 enhancement New feature or request accepted True. labels Feb 21, 2023
@WesleyVanNeck
Copy link
Member

@siyy123 @LegacyGamerHD What is the status on this?

not much am prety bussy with life

@josephworks
Copy link
Member

Same! No worries!

@ghost
Copy link
Author

ghost commented Feb 22, 2023

@siyy123 @LegacyGamerHD What is the status on this?

busy too.
jdk9+ support would be ok if the patch system can work but I do not have time to test :(

@FatSaw
Copy link
Contributor

FatSaw commented Feb 25, 2023

I tryed launch akarin with mixin 8.3.
And it try to load modlauncher bootstarp:"org.spongepowered.asm.service.modlauncher.MixinServiceModLauncherBootstrap".
I think it should load "org.spongepowered.asm.service.mojang.MixinServiceLaunchWrapperBootstrap" to work with LegacyLauncher.

@WesleyVanNeck
Copy link
Member

I tryed launch akarin with mixin 8.3. And it try to load modlauncher bootstarp:"org.spongepowered.asm.service.modlauncher.MixinServiceModLauncherBootstrap". I think it should load "org.spongepowered.asm.service.mojang.MixinServiceLaunchWrapperBootstrap" to work with LegacyLauncher.

it s not done yet

@FatSaw
Copy link
Contributor

FatSaw commented Feb 26, 2023

it s not done yet

I know.

I was building mixin 8.3 for tests and found another possible problem.
paper-api uses "org.ow2.asm" v6._ , mixin 8.3 uses "org.ow2.asm" v7._
it may have dependency conflict.

@FatSaw
Copy link
Contributor

FatSaw commented Feb 26, 2023

LegacyLauncher has issues working with mixin 8+. I suggest replacing it with ignite: https://github.com/vectrix-space/ignite

@FatSaw
Copy link
Contributor

FatSaw commented Feb 27, 2023

Experimental version with 8.5 mixin: https://github.com/FatSaw/Akarin/tree/upstream-mixin-EXPERIMENTAL
Built with eclipse.

@WesleyVanNeck
Copy link
Member

Why not pull request it to us

@FatSaw
Copy link
Contributor

FatSaw commented Mar 5, 2023

#240 #241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.12.2 This issue was found in version 1.12.2 accepted True. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants