Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location choice logsum overwritten with mode choice logsum in estimation mode #897

Open
dhensle opened this issue Oct 2, 2024 · 0 comments
Labels
Bug Something isn't working/bug f

Comments

@dhensle
Copy link
Contributor

dhensle commented Oct 2, 2024

Describe the bug
The location choice logsum gets overwritten by the mode choice logsum in location choice when running in estimation mode.

To Reproduce
Run the estimation example with the DEST_CHOICE_LOGSUM_COLUMN_NAME set in the workplace or school location yaml.

Expected behavior
The location choice logsum should be the location choice logsum, not the mode choice logsum.

Screenshots
workplace location and modechoice logsums are the same, as seen in the below trace
image

Additional context
This only occurs in estimation mode. The previous code unnecessarily overwrote the location choice logsum with the mode choice logsum of the selected alternative. Based on the code, it seems this was done because the previous coder did not fully comprehend the difference between the location and modechoice logsums, thus treating them as the same. This was also likely complicated by the fact that we now allow the user to return both the modechoice and location choice logsums separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working/bug f
Projects
None yet
Development

No branches or pull requests

1 participant