Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IS-04-02] test_23_1 Not working on a v1.0 node resource. #781

Open
MongareAlex opened this issue Apr 3, 2023 · 3 comments
Open

[IS-04-02] test_23_1 Not working on a v1.0 node resource. #781

MongareAlex opened this issue Apr 3, 2023 · 3 comments

Comments

@MongareAlex
Copy link

The test seems to be querying on a description attribute which is not available on a v1.0 node.

Here is the Traceback (most recent call last):

File "C:Sandbox\nmos-testing-master (1)\nmos-testing-master\nmostesting\GenericTest.py", line 164, in execute_test self.result.append(method(test)) ^^^^^^^^^^^^ File "C:Sandbox\nmos-testing-master (1)\nmos-testing-master\nmostesting\suites\IS0402Test.py", line 1422, in test_23_1 if post_data["description"] != node_ids[0]: ~~~~~~~~~^^^^^^^^^^^^^^^ KeyError: 'description'

@garethsb
Copy link
Contributor

garethsb commented Apr 3, 2023

Thanks for the report. You are correct. IS-04 v1.0 Node resources didn't have description. And the Query API didn't define any queryParameters in the RAML. A Registry may quite correctly not support queries on this attribute at v1.0.

Probably the simplest fix is to use mock Device resources in these tests rather than Node resources.

Since IS-04 v1.3 is already 3.5 years old, and v1.2 (minimum for JT-NM Tested) is nearly 5 years old, this issue may not get fixed immediately.

@MongareAlex
Copy link
Author

Alright, will consider mocking with a device resource.

@garethsb
Copy link
Contributor

garethsb commented Apr 4, 2023

Reopening as should be fixed.

@garethsb garethsb reopened this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants