Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sender-stage-success.json does not match Schema activation-response-schema.json #171

Open
kierank opened this issue Nov 1, 2023 · 3 comments

Comments

@kierank
Copy link

kierank commented Nov 1, 2023

The example Sender Stage Succes https://specs.amwa.tv/is-05/releases/v1.1.2/examples/sender-stage-success.html does not match the Schema https://specs.amwa.tv/is-05/releases/v1.1.2/APIs/schemas/resolved/sender-response-schema.html for "activation-time".

https://specs.amwa.tv/is-05/releases/v1.1.2/examples/sender-stage-success-redundant-streams.html has the same issue.

@garethsb
Copy link
Contributor

garethsb commented Nov 1, 2023

Thanks, @kierank. Specifically, these examples do not comply with the sentence "For immediate activations on the staged endpoint this property [activation_time] will be the time the activation actually occurred in the response to the PATCH request".

@matthewdicken
Copy link

matthewdicken commented Nov 3, 2023

In relation to this, the /staged endpoints are missing example JSON for a GET request after an immediate activation took place. "receiver-stage-success" is what the receiver's /staged endpoint should return in response to a PATCH request. "receiver-stage-scheduled-" is the result of a GET request on the /staged endpoint whilst an activation is pending. But there isn't one for GET /staged following an immediate activation (equivalent to receiver-active-get-200)

Or is this it?
https://specs.amwa.tv/is-05/releases/v1.1.2/examples/sender-get-200.html

@matthewdicken
Copy link

Also, the descriptions in the activation response schema talk specifically about the response and /staged endpoint, but with no mention of the /active endpoint. One could infer that the wording "will be null in response to any subsequent GET requests" might also apply to the /active endpoint, but these both need to be set in order to pass IS-05 test_25, whereas currently the requested_time must be set to NULL in order to pass, even though the example shows the field as populated.

https://specs.amwa.tv/is-05/releases/v1.1.2/APIs/schemas/with-refs/activation-response-schema.html
https://specs.amwa.tv/is-05/releases/v1.1.2/examples/sender-active-get.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants