Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] provide default prompt for fish shell #1571

Open
scarf005 opened this issue Sep 28, 2024 · 2 comments
Open

[Suggestion] provide default prompt for fish shell #1571

scarf005 opened this issue Sep 28, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@scarf005
Copy link

Is your feature request related to a problem? Please describe.

it's easy to distinguish you're inside a box on bash thanks to a custom prompt like 📦[scarf@fedora scarf]$:

distrobox/distrobox-init

Lines 2028 to 2031 in c05b6a4

if [ -f /run/.toolboxenv ]; then
[ "\${BASH_VERSION:-}" != "" ] && PS1="📦[\u@\$CONTAINER_ID \W]\$ "
[ "\${ZSH_VERSION:-}" != "" ] && PS1="📦[%n@\$CONTAINER_ID]%~%# "
fi

however there isn't one for fish, making it hard to determine whether you're on host or box.

Describe the solution you'd like

provide default fish shell prompt inside distrobox.

Describe alternatives you've considered

provide guide on how to set up custom fish prompt that detects whether you're inside a box and shows prompt accordingly.

Additional context

i'm interested in opening a PR.

@scarf005 scarf005 added the enhancement New feature or request label Sep 28, 2024
@89luca89
Copy link
Owner

Thanks @scarf005 i'm open to contributions on this, I have no experience at all with fish shell

@89luca89 89luca89 added help wanted Extra attention is needed good first issue Good for newcomers labels Oct 12, 2024
@Boria138
Copy link
Contributor

Thanks @scarf005 i'm open to contributions on this, I have no experience at all with fish shell

#1588

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants