Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl: Redirect paths starting with /public/ when not Authed #14

Open
2 tasks
5HT2 opened this issue Jun 18, 2024 · 0 comments
Open
2 tasks

impl: Redirect paths starting with /public/ when not Authed #14

5HT2 opened this issue Jun 18, 2024 · 0 comments
Labels
enhancement New feature or request
Milestone

Comments

@5HT2
Copy link
Owner

5HT2 commented Jun 18, 2024

Ideally, when an Auth header is not provided, if a user is given a link such as https://cdn.frogg.ie/public/pdfs/, or a specific file, it should redirect to https://cdn.frogg.ie/pdfs/ (or the specific file), if it exists.

This is preferable over being handed a 404, and if you have the URL of an existing file you could already remove the /public/ from the URL yourself.

The only downside I could see this having is it being confusing in some cases?? Maybe? Like, if you thought you had provided an Auth and weren't expecting it to serve non-Authed content.

  • The only cases where this really matters could easily be mitigated by only redirecting on GET and nothing else, to avoid rewriting real edit requests.

  • Maybe this be configurable??

  • Maybe config options allow enabling this only for folder paths?

@5HT2 5HT2 added the enhancement New feature or request label Jun 18, 2024
@5HT2 5HT2 added this to the v2 milestone Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant