Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended-data-d3-timeseries-graph Check: additionalData can be null #111

Open
ChrisMalewski opened this issue Oct 7, 2019 · 2 comments
Open
Labels

Comments

@ChrisMalewski
Copy link

ChrisMalewski commented Oct 7, 2019

Check: additionalData can be null

https://github.com/52North/helgoland-toolbox/blob/develop/projects/helgoland/d3/src/lib/extended-data-d3-timeseries-graph/extended-data-d3-timeseries-graph.component.ts : Line 99

@ktsrivastava29
Copy link

I note that this issue was brought up long ago and has not been resolved. I want to work on this issue.
Since there doesn't seem to be much activity at this repository, i'd like to know if it's still active. Is there another repository where all operations are carried out?

@swapniljadhav96
Copy link

If additionalData can be null at line 99, you should guard against this possibility to avoid errors. You can add a null check before iterating over this.additionalData.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants