Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing old hostsfile entries on DHCP #38

Open
timurb opened this issue Dec 26, 2014 · 1 comment
Open

removing old hostsfile entries on DHCP #38

timurb opened this issue Dec 26, 2014 · 1 comment

Comments

@timurb
Copy link
Contributor

timurb commented Dec 26, 2014

Hi, thanks for a great piece of software!

I've just noticed a minor issue which I'd like to have fixed:

When you are running an EC2 instance outside of VPC (or simply when a server receives an IP via DHCP) on the next poweroff/startup cycle it is going to get a new IP address. The cookbook will create a new hostsfile entry but will not remove the old one.

This is probably ok for most cases but for some software like Hadoop it becomes critical.

To deal with that you just have to add unique true to the hostsfile_entry[set hostname] resource.
I'd create a pull request for that but I wanted to discuss first, do you think it should be made configurable so that you could keep an old behaviour if needed? Or do you think just putting unique true there would be ok?

@xamebax
Copy link
Contributor

xamebax commented Dec 29, 2014

Hey, thanks!

Unfortunately, I have no experience with Hadoop, but from what I understand, this seems to be a good idea. I'm not sure whether it has to be configurable, but maybe @mpasternacki could chime in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants