Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major version upgrade plan #488

Open
TonisOrmisson opened this issue Dec 26, 2022 · 17 comments
Open

Major version upgrade plan #488

TonisOrmisson opened this issue Dec 26, 2022 · 17 comments
Assignees
Milestone

Comments

@TonisOrmisson
Copy link
Contributor

Bootstrap here is outdated, no releases lately make hard to implement breaking changes. I suggest a plan for getting past this

1. I have created a dev branch here:

https://github.com/TonisOrmisson/yii2-usuario/tree/bootstrap-5

This branch will:

  • move resources away from src folder
  • make all views-related dependencies as non-mandatory
  • implements bootstrap5 in the "default" views
  • Docs not updated yet

2. create a new bs5 branch

Since there has not been a release for quite a long time and I am guessing many are using the module via "dev-master". I do not want to make a PR into master to start with. I suggest to implement the changes in a TEMP parallel branch. Eg v2 or similar.

3. Make a release

Make a release of the current work (eg 1.6) and announce a deadline for the merge of the TEMP branch into master. Suggest users to avoid using "dev-master" and use the latest tagged release instead (breaking changes incoming). I suggest no longer than 6 months for the deadline.

4. Tag a v2 release on the TEMP branch to be able to pull a versioned new release.

5. Merge

after the "deadline" merge the Temp branch to master and kill the temp branch.


related to #437 #476 #289 #406 #485

@DikkiX
Copy link

DikkiX commented Dec 27, 2022

we need this frr

@maxxer maxxer self-assigned this Dec 27, 2022
@maxxer maxxer added this to the 1.6.0 milestone Dec 27, 2022
@maxxer
Copy link
Collaborator

maxxer commented Dec 27, 2022

I'll set the release goal for the first week of Jan. Feel free to ping me obsessively if I don't!

@maxxer
Copy link
Collaborator

maxxer commented Dec 29, 2022

https://github.com/2amigos/yii2-usuario/releases/tag/1.6.0-beta1

@DikkiX
Copy link

DikkiX commented Jan 3, 2023

https://github.com/2amigos/yii2-usuario/releases/tag/1.6.0-beta1

When is official release for bs5?

@maxxer
Copy link
Collaborator

maxxer commented Jan 3, 2023

After we tag 1.6, Tõnis will issue a PR for it.

@maxxer
Copy link
Collaborator

maxxer commented Jan 9, 2023

1.6.0 released, we can move forward.

@maxxer
Copy link
Collaborator

maxxer commented Jan 9, 2023

@TonisOrmisson how would you like to proceed? Shall I create a v2 branch and merge your repo in it?

@TonisOrmisson
Copy link
Contributor Author

This is how I imagined it, yes. Any better ideas are welcome of course. BTW my bs5 version still lacks all changes in documentation. But if you create a new branch I will happily submit a PR there

@maxxer
Copy link
Collaborator

maxxer commented Jan 9, 2023

https://github.com/2amigos/yii2-usuario/tree/v2.0.0-dev

So as for now I'll keep merging stable stuff into master

@TonisOrmisson
Copy link
Contributor Author

ok, seems I have a bit of an old state of views in my bs5 version so I'll recreate my bs5 changes on a fresh copy of views not to make a mess. Hope to submit that in a couple of days to this out to testing asap.

@TonisOrmisson
Copy link
Contributor Author

Merge master to v2.0.0-dev @maxxer ?

@maxxer
Copy link
Collaborator

maxxer commented May 8, 2023

Done!

@TonisOrmisson
Copy link
Contributor Author

Merge master to v2.0.0-dev @maxxer ?

@maxxer
Copy link
Collaborator

maxxer commented Feb 15, 2024

Done!

@TonisOrmisson
Copy link
Contributor Author

I have started migrating my some projects to use with the new v2 and BS5 based views. So far no major issues. But a question to all of you. Since v2 is a major version change, I suggest also to drop support for php 7. Please do speak out loud if you oppose this :) Post an emoji to here for pro/con

@TonisOrmisson
Copy link
Contributor Author

we have done most of the plan for preparing v2 release. How can we move forward?

I suggest we should copy the current master branch to a new v1 branch and then merge the v2.0.0-dev into master if we are ready to do so.

also we have an "old" usuario-2.0-dev branch that should be renamed to refer that it is basically an abandoned branch and not related to actual v2

Any ideas what would need to be done before merging?

@TonisOrmisson
Copy link
Contributor Author

Merge master to v2.0.0-dev again @maxxer to keep in sync ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants