From b522e2bc01a21bde3aee407bbccb632fb871bd96 Mon Sep 17 00:00:00 2001
From: Chris Blyth <blythmeister@gmail.com>
Date: Thu, 16 May 2024 16:29:17 +0100
Subject: [PATCH] Improve logging and splitting of knownResources

---
 src/Scripts/kubernetesHelper.ps1 | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/src/Scripts/kubernetesHelper.ps1 b/src/Scripts/kubernetesHelper.ps1
index 30ba2e60..863bb913 100644
--- a/src/Scripts/kubernetesHelper.ps1
+++ b/src/Scripts/kubernetesHelper.ps1
@@ -259,7 +259,7 @@ function GetResourceVersionsUsed([string]$kubernetesConfigFile, [string]$selecto
     Write-Host "Get Accessible Resources"
     $resourceVersions = @()
     $resources = @()
-    $knownResourcesArray = $knownResources -Split ","
+    $knownResourcesArray = $knownResources.Split(",",[System.StringSplitOptions]::RemoveEmptyEntries)
 
     $rawResources = & $KubeCtlExe api-resources --verbs=list --namespaced -o name --kubeconfig=$kubernetesConfigFilePath
 
@@ -269,6 +269,11 @@ function GetResourceVersionsUsed([string]$kubernetesConfigFile, [string]$selecto
         exit $LASTEXITCODE
     }
 
+    if($knownResourcesArray.Count -ne 0)
+    {
+        Write-Host "Known Resource Types: $knownResourcesArray"
+    }
+
     foreach($resource in $rawResources)
     {
         if ($resource.Contains("."))
@@ -280,15 +285,23 @@ function GetResourceVersionsUsed([string]$kubernetesConfigFile, [string]$selecto
         {
             if ($resources -notcontains $resource)
             {
-                Write-Host "  Checking $resource is accessible"
                 $cani = & $KubeCtlExe auth can-i list $resource --kubeconfig=$kubernetesConfigFilePath
 
                 if ($LASTEXITCODE -eq 0 -and $cani -eq "yes")
                 {
+                    Write-Host "  * $resource (accessible)"
                     $resources += $resource
                 }
+                else
+                {
+                    Write-Host "  * $resource (not accessible)"
+                }
             }
         }
+        else
+        {
+            Write-Host "  * $resource (not checked)"
+        }
     }
 
     if ($resources.Count -gt 0)