Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excessive use of unchecked unwraps #100

Open
yaleman opened this issue Aug 24, 2024 · 1 comment
Open

Excessive use of unchecked unwraps #100

yaleman opened this issue Aug 24, 2024 · 1 comment

Comments

@yaleman
Copy link

yaleman commented Aug 24, 2024

Example: get_blob(&self, alg: &PubKey) -> Vec<u8>

This has unwraps for values that could be None so rather than checking for error states it just causes consumers to panic. It really shouldn't be used like this, rather the return of get_blob should be a Result type...

I'm somehow triggering this because it can't read one of my (perfectly valid) ssh keys properly, which is strange 😢

@yaleman
Copy link
Author

yaleman commented Aug 24, 2024

I figured out what the issue likely is - the key has a passphrase which there's seemingly no way to configure in this library?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant