Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on side branches #15

Open
FabijanC opened this issue Jun 15, 2023 · 0 comments · May be fixed by #18
Open

Build on side branches #15

FabijanC opened this issue Jun 15, 2023 · 0 comments · May be fixed by #18
Assignees

Comments

@FabijanC
Copy link
Collaborator

FabijanC commented Jun 15, 2023

Currently we only build on master, but for testing purposes, we could build on side branches, too. This is useful if we aren't just doing a simple cairo-lang update, but e.g. adding new commands.

It could be a simple build of just one image. Don't know how we would handle the environment variables (ARGs), ideally we wouldn't introduce duplication.

EDIT: the simplest approach would be to add a check in the shell script which checks the CIRCLE_BRANCH (an environment variable present in circleci) and only pushes the images if on master.

@Nathan-SL Nathan-SL self-assigned this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants