From 773742ba060ed50799a73f64e41aa2d79165bab2 Mon Sep 17 00:00:00 2001 From: leovct Date: Tue, 1 Oct 2024 16:34:57 +0200 Subject: [PATCH 1/6] ci: dump enclave logs --- .github/workflows/deploy.yml | 44 ++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 0cc7026f..02980a80 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -39,6 +39,17 @@ jobs: - name: Monitor verified batches (CDK Erigon Permissionless RPC) working-directory: .github/scripts run: ./monitor-verified-batches.sh --rpc-url $(kurtosis port print ${{ env.ENCLAVE_NAME }} cdk-erigon-node-001 rpc) + + - name: Dump enclave logs + if: always() + run: kurtosis dump ./dump + + - name: Upload logs + if: always() + uses: actions/upload-artifact@v4 + with: + name: dump_run_without_args_${{ github.run_id }} + path: ./kurtosis-cdk/dump list-ymls: runs-on: ubuntu-latest @@ -105,6 +116,17 @@ jobs: else echo "Skipping batch verification as there is no zkevm permissionless RPC in the environment" fi + + - name: Dump enclave logs + if: always() + run: kurtosis dump ./dump + + - name: Upload logs + if: always() + uses: actions/upload-artifact@v4 + with: + name: dump_run_with_args_${{ matrix.file_name }}_${{ github.run_id }} + path: ./kurtosis-cdk/dump additional_services: runs-on: ubuntu-latest @@ -150,6 +172,17 @@ jobs: echo "❌ Prometheus does not collect panoptichain metrics..." exit 1 fi + + - name: Dump enclave logs + if: always() + run: kurtosis dump ./dump + + - name: Upload logs + if: always() + uses: actions/upload-artifact@v4 + with: + name: dump_additional_services_${{ github.run_id }} + path: ./kurtosis-cdk/dump attach_cdks: runs-on: ubuntu-latest @@ -189,3 +222,14 @@ jobs: - name: Monitor verified batches of the second L2 chain (CDK Erigon Permissionless RPC) working-directory: .github/scripts run: ./monitor-verified-batches.sh --rpc-url "$(kurtosis port print ${{ env.ENCLAVE_NAME }} cdk-erigon-node-002 rpc)" + + - name: Dump enclave logs + if: always() + run: kurtosis dump ./dump + + - name: Upload logs + if: always() + uses: actions/upload-artifact@v4 + with: + name: dump_attach_ckds_${{ github.run_id }} + path: ./kurtosis-cdk/dump From 9a124eb65dbe4047e66d6024bd2e63c0d4f7e6a6 Mon Sep 17 00:00:00 2001 From: leovct Date: Tue, 1 Oct 2024 16:38:40 +0200 Subject: [PATCH 2/6] fix: only run on failures --- .github/workflows/deploy.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 02980a80..02e01b6e 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -41,11 +41,11 @@ jobs: run: ./monitor-verified-batches.sh --rpc-url $(kurtosis port print ${{ env.ENCLAVE_NAME }} cdk-erigon-node-001 rpc) - name: Dump enclave logs - if: always() + if: failure() run: kurtosis dump ./dump - name: Upload logs - if: always() + if: failure() uses: actions/upload-artifact@v4 with: name: dump_run_without_args_${{ github.run_id }} @@ -118,11 +118,11 @@ jobs: fi - name: Dump enclave logs - if: always() + if: failure() run: kurtosis dump ./dump - name: Upload logs - if: always() + if: failure() uses: actions/upload-artifact@v4 with: name: dump_run_with_args_${{ matrix.file_name }}_${{ github.run_id }} @@ -174,11 +174,11 @@ jobs: fi - name: Dump enclave logs - if: always() + if: failure() run: kurtosis dump ./dump - name: Upload logs - if: always() + if: failure() uses: actions/upload-artifact@v4 with: name: dump_additional_services_${{ github.run_id }} @@ -224,11 +224,11 @@ jobs: run: ./monitor-verified-batches.sh --rpc-url "$(kurtosis port print ${{ env.ENCLAVE_NAME }} cdk-erigon-node-002 rpc)" - name: Dump enclave logs - if: always() + if: failure() run: kurtosis dump ./dump - name: Upload logs - if: always() + if: failure() uses: actions/upload-artifact@v4 with: name: dump_attach_ckds_${{ github.run_id }} From 328fb1154820c4b31ca76a7e212f0d55cf01abb9 Mon Sep 17 00:00:00 2001 From: leovct Date: Tue, 1 Oct 2024 16:57:29 +0200 Subject: [PATCH 3/6] test: attempt to make the ci fail --- .github/workflows/deploy.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 02e01b6e..1f14aeea 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -40,6 +40,9 @@ jobs: working-directory: .github/scripts run: ./monitor-verified-batches.sh --rpc-url $(kurtosis port print ${{ env.ENCLAVE_NAME }} cdk-erigon-node-001 rpc) + - name: Make the CI fail on purpose + run: exit 1 + - name: Dump enclave logs if: failure() run: kurtosis dump ./dump From 5e476b60a9c295e00e33f04101c7d44741bec3d0 Mon Sep 17 00:00:00 2001 From: leovct Date: Tue, 1 Oct 2024 17:16:22 +0200 Subject: [PATCH 4/6] fix: dump path --- .github/workflows/deploy.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 1f14aeea..27cbcfd0 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -52,7 +52,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: dump_run_without_args_${{ github.run_id }} - path: ./kurtosis-cdk/dump + path: ../dump list-ymls: runs-on: ubuntu-latest @@ -129,7 +129,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: dump_run_with_args_${{ matrix.file_name }}_${{ github.run_id }} - path: ./kurtosis-cdk/dump + path: ../dump additional_services: runs-on: ubuntu-latest @@ -185,7 +185,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: dump_additional_services_${{ github.run_id }} - path: ./kurtosis-cdk/dump + path: ../dump attach_cdks: runs-on: ubuntu-latest @@ -235,4 +235,4 @@ jobs: uses: actions/upload-artifact@v4 with: name: dump_attach_ckds_${{ github.run_id }} - path: ./kurtosis-cdk/dump + path: ../dump From 10a6f5aa1b8db4be814e81e8869075af7c64e398 Mon Sep 17 00:00:00 2001 From: leovct Date: Tue, 1 Oct 2024 17:17:08 +0200 Subject: [PATCH 5/6] fix: typo --- .github/workflows/deploy.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 27cbcfd0..b8dd6a76 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -39,7 +39,7 @@ jobs: - name: Monitor verified batches (CDK Erigon Permissionless RPC) working-directory: .github/scripts run: ./monitor-verified-batches.sh --rpc-url $(kurtosis port print ${{ env.ENCLAVE_NAME }} cdk-erigon-node-001 rpc) - + - name: Make the CI fail on purpose run: exit 1 @@ -52,7 +52,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: dump_run_without_args_${{ github.run_id }} - path: ../dump + path: ./dump list-ymls: runs-on: ubuntu-latest @@ -119,7 +119,7 @@ jobs: else echo "Skipping batch verification as there is no zkevm permissionless RPC in the environment" fi - + - name: Dump enclave logs if: failure() run: kurtosis dump ./dump @@ -129,7 +129,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: dump_run_with_args_${{ matrix.file_name }}_${{ github.run_id }} - path: ../dump + path: ./dump additional_services: runs-on: ubuntu-latest @@ -175,7 +175,7 @@ jobs: echo "❌ Prometheus does not collect panoptichain metrics..." exit 1 fi - + - name: Dump enclave logs if: failure() run: kurtosis dump ./dump @@ -185,7 +185,7 @@ jobs: uses: actions/upload-artifact@v4 with: name: dump_additional_services_${{ github.run_id }} - path: ../dump + path: ./dump attach_cdks: runs-on: ubuntu-latest @@ -235,4 +235,4 @@ jobs: uses: actions/upload-artifact@v4 with: name: dump_attach_ckds_${{ github.run_id }} - path: ../dump + path: ./dump From 9721d779d1071a290d215f0ca6ed1d184e360190 Mon Sep 17 00:00:00 2001 From: leovct Date: Tue, 1 Oct 2024 18:13:39 +0200 Subject: [PATCH 6/6] test: remove exit 1 --- .github/workflows/deploy.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index b8dd6a76..6b97d7ab 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -40,9 +40,6 @@ jobs: working-directory: .github/scripts run: ./monitor-verified-batches.sh --rpc-url $(kurtosis port print ${{ env.ENCLAVE_NAME }} cdk-erigon-node-001 rpc) - - name: Make the CI fail on purpose - run: exit 1 - - name: Dump enclave logs if: failure() run: kurtosis dump ./dump